fix: normalize Windows path casing in config warning - #16239
Closed
LogicDX342 wants to merge 1 commit into
Closed
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/7689adc00e515a87c0b22338045ce3b85362b952Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 7689adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
elliott-with-the-longest-name-on-github
previously approved these changes
Jul 7, 2026
elliott-with-the-longest-name-on-github
dismissed
their stale review
July 7, 2026 22:06
Accidental approval; need to discuss on Thursday
Member
|
See #16293 (comment) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes false positive Vite config override warnings on Windows when SvelteKit compares equivalent filesystem paths with different casing.
SvelteKit already normalizes path separators before comparing enforced Vite config values. However, on Windows, path casing can also differ between the incoming config and resolved config, for example
e:/...vsE:/.... Those paths refer to the same filesystem location, but the current string comparison can still report an override warning such as:This PR normalizes casing on Windows for enforced config values that are filesystem paths.
Related issue: #16293
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits