fix: ignore path casing differences in Vite config override warning - #16405
Closed
Nic-Polumeyv wants to merge 1 commit into
Closed
fix: ignore path casing differences in Vite config override warning#16405Nic-Polumeyv wants to merge 1 commit into
Nic-Polumeyv wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d05ce4115b6005a5123d372277caa9a4cbfd7d4dOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d05ce41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 20, 2026
Contributor
Author
|
Replaced by #16545 against version-3, since main is winding down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16317, follow-up to #16037 which normalized separators for this warning but left the comparison case-sensitive. #16239 addressed the same casing issue with a per-key whitelist before it was closed alongside #16293.
During
svelte-check,@sveltejs/load-configresolves the Vite config with an explicitrootderived from directory traversal (loadSvelteConfigFromVitepasses{ root, configFile }and chdirs first), so the config SvelteKit's plugin receives always containsroot, and it gets compared against SvelteKit'sposixify(process.cwd()). The two strings match exactly on Linux, which is why the warning only ever shows on Windows, where the two routes can disagree on casing (typically the drive letter) and #16037's slash normalization doesn't help. That matches #16317 still reproducing on 2.69.2 after #16293 was closed as unreproducible on non-Windows. Windows paths are case-insensitive, so the comparison now folds case on win32.Traced by instrumenting
find_overridden_config, Vite'sresolveConfigandrunConfigHookin a fresh kit 2.69.2 + svelte-check 4.7.3 app. Validated by injecting a case-only difference into that flow, where the current comparison prints the reported warning, the fixed one stays silent, and a genuineappTypeoverride still warns. The reporter has since confirmed the case-only difference on real Windows in #16317 (comment). Like #16037 there is no test, the function is internal and the behaviour platform-specific.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits