fix: yield to allow prerender updates to be visible - #16748
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/fc53a3f683f403388167257784b0ee16986119c3Open in |
🦋 Changeset detectedLatest commit: fc53a3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
left a comment
Contributor
There was a problem hiding this comment.
separately: nothing clears the last rendering /x line after q.done(), so the build still ends looking stuck through the manifest/adapter steps
Co-authored-by: Nic Polumeyv <nicolas.polum@outlook.com>
teemingc
approved these changes
Aug 12, 2026
Rich-Harris
pushed a commit
that referenced
this pull request
Aug 12, 2026
…s line (#16750) If app code writes to stdout without a trailing newline during prerendering on a TTY, the next progress line lands on the same row and the update after that clears the row: ``` rendering /partial... rendering /dynamic/foo... <- app output destroyed ``` The write proxies now track whether the last chunk ended mid-line, and the progress line starts a fresh row instead: ``` rendering /partial... IMPORTANT APP OUTPUT (no newline) rendering /dynamic/foo... ``` surfaced while reviewing #16748
Rich-Harris
pushed a commit
that referenced
this pull request
Aug 12, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.21 ### Major Changes - breaking: move remote function types and `isValidationError` to `@sveltejs/kit/remote` ([#16764](#16764)) - breaking: move `RequestEvent` and `Cookies` to `$app/server` ([#16751](#16751)) ### Patch Changes - fix: correctly implement Vite plugin hook filters ([#16760](#16760)) - fix: yield to allow prerender updates to be visible ([#16748](#16748)) - fix: don't destroy partial-line app output with the prerender progress line ([#16750](#16750)) ## @sveltejs/package@3.0.0-next.7 ### Patch Changes - chore: bump `svelte2tsx` to 0.7.60 ([#16745](#16745)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #16744 — turns out we need this or
stdoutcan buffer updates for long enough that progress appears stalled.before:
logging-before.mov
after:
logging-after.mov
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits