breaking: move RequestEvent and Cookies to $app/server - #16751
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/20840d891b0f4d132b9a5f7e207b61362f7f1c45Open in |
🦋 Changeset detectedLatest commit: 20840d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
approved these changes
Aug 12, 2026
Rich-Harris
pushed a commit
that referenced
this pull request
Aug 12, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.21 ### Major Changes - breaking: move remote function types and `isValidationError` to `@sveltejs/kit/remote` ([#16764](#16764)) - breaking: move `RequestEvent` and `Cookies` to `$app/server` ([#16751](#16751)) ### Patch Changes - fix: correctly implement Vite plugin hook filters ([#16760](#16760)) - fix: yield to allow prerender updates to be visible ([#16748](#16748)) - fix: don't destroy partial-line app output with the prerender progress line ([#16750](#16750)) ## @sveltejs/package@3.0.0-next.7 ### Patch Changes - chore: bump `svelte2tsx` to 0.7.60 ([#16745](#16745)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
I opened a PR to revert this. Thoughts welcome #16772 |
Rich-Harris
added a commit
that referenced
this pull request
Aug 13, 2026
Reverts #16751. Moving `RequestEvent` and `Cookies` to `$app/server` was a reasonable enough idea but it leaves an awkward asymmetry with `ServerLoadEvent` (which extends `RequestEvent` but remains in `@sveltejs/kit`) and `LoadEvent` (which extends `NavigationEvent`; both of these are also in `@sveltejs/kit`). We _could_ move `ServerLoadEvent` to `$app/server` instead, though then we would probably need to move `ServerLoad`, and at that point we should probably also consider moving `Action`/`Actions`/`ActionFailure`/`AwaitedActions` there too, and if we're moving stuff that defines exports from route files then it would probably be weird to leave `PrerenderOption` behind (except that obviously doesn't belong in `$app/server`). And if we did that, we should probably move `LoadEvent` and `NavigationEvent` to... `$app/navigation` presumably? But then we would also want to move `Load` and `LoadProperties` there and I'm not sure how I feel about that. I'm not 100% on any of this. But I think the safest option is _probably_ to move `RequestEvent` and `Cookies` back to the `@sveltejs/kit` dumping ground. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16676