make export use filters, add tests - #164
Merged
Merged
Conversation
jacalata
commented
Aug 24, 2022
Contributor
- updated export command to look for filter params on the url given and convert them to RequestOption view_filters
- fixed bytes v iterator for data files.
- added tests
| except BaseException as e: | ||
| logger.error("Error building filter params", e) | ||
| ExportCommand.log_stack(logger) # type: ignore | ||
| return request_options |
Collaborator
There was a problem hiding this comment.
Do we even need to return request_options here? I'm assuming the original request_options argument passed in will have its view_filters field updated.
Contributor
Author
There was a problem hiding this comment.
good call, we do not. Fixed.
Collaborator
There was a problem hiding this comment.
Was this one still pending?
rename method, remove println, also add smoother handling for unnecessary / character
jacalata
added a commit
that referenced
this pull request
Sep 12, 2022
* --save-db-password flag thinks it should get an argument *updated several other publishing arguments that had the same problem * change argument from "token" to "token-value" so it is not a substring of "token-name", remove the 2-letter short arguments * fix reencrypt_extracts help string * Hand format a nice help output * Fix exit_with_error handling * Defect 1426885: [Tabcmd WAM] addusers and removeusers error * fix deletegroup * update unlocalized strings * clearly indicate when using the default site * Fix export success log message params (#142) * Jac/tfs 1428582 create edit site (#146) * Getting workbook works as expected, but appends extra file extensions * Fix get view, get csv (#143) * Change install destination (#150) * Defect 1428581: [Tabcmd WAM] Publishing to projects other than default throws an error * Jac/delete command (#144) * filter for items in project * separate the use of ds/wb as flags vs as argument names * update publish_samples to call shared project logic * Add command to list items of a given content type (#153) * make export use filters, add tests (#164) * Add trace logging details and error stack * handle url input more robustly Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>
jacalata
added a commit
that referenced
this pull request
Nov 10, 2022
Dropped support for python < 3.9 Changed argument from "token" to "token-value" so it is not a substring of "token-name", remove the 2-letter short arguments Release 2.0.6 * add step to list dependencies for licensing * Defect 1427376: [Tabcmd WAM] --save-db-password flag thinks it should get an argument (#134) * Fix exit_with_error handling (#137) * TFS 1428581 publish project (#139) * Defect 1426885: [Tabcmd WAM] addusers and removeusers error, fix deletegroup (#140) * clearly indicate when using the default site (#141) * Fix export success log message params (#142) * Jac/tfs 1428582 create edit site (#146) * Fix get view, get csv file extensions (#143) * Change install destination to /tabcmd instead of /src (#150) * Defect 1428581: [Tabcmd WAM] Publishing to projects other than default throws an error (#145) * Jac/delete command (#144) * Jac/e2e test workflow (#154) * Add command to list items of a given content type (#153) * make export use filters, add tests (#164) * Fix some e2e tests (#166) * Trace logging and bug fix (#165) Release 2.0.7 * Implement command line and url parameters for get/export (#175) * recognize more values for yes on command line (#173) * fully port to pyproject.toml (#182) * implement pdf layout/page type (#184, #169) * tfs 1427025: Confusing error message related to sign-in (#187), (#190) * stop duplicate logging in session * extract encryption defaults to false (#193) * call sites endpoint correctly (#194) * publish data source to Tableau Cloud for published live connection with Tableau Bridge (#195) Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.