Add standard shelf keyboard actions - #1
Conversation
…field Three corrections to the new shelf shortcuts. ⌘C acted on `primaryItem` while ⌘V and ⌘⌫ both act on the whole selection, so it was the one multi-select gesture that quietly did something else. `copySelection` now mirrors `pasteSelection`: one card copies its full representations, several copy their joined text, because the pasteboard holds one item at a time. ⌘C and ⌘V now only claim the key when the search box is empty. The shelf keeps that field focused at all times, so the unguarded versions took the one key needed to paste a search term in and to copy it back out. With text in the field both fall through to `default`, which is what Backspace in the same switch already does. Drops the notification the copy posted. Nothing listened to it here, the app defines no other `Notification.Name`, and the sound feature can call its player from `copyToClipboard` directly instead of going through a stringly-typed event.
4cd6bf6 to
62df2a1
Compare
|
Good first contribution, and thanks for the backstory. The Backspace handling in particular is right: it lets the existing pill handler run first and returns I rebased on main and pushed one commit with three corrections:
I kept the ⌘, settings fix even though it is unrelated to the title. It is a real fix and splitting it now would be churn. Worth its own PR next time. Builds clean, 187 tests pass. Merging. |
Hi! A little backstory: my Paste subscription came up for renewal, and I realized I was not ready to keep paying for it. I asked my Codex agent to look for alternatives; among several similar projects, Copy was the one I liked most. I would be happy to contribute improvements here—straightforward fixes as pull requests, and more opinionated ideas as issues.
What changed
Testing
swift test --package-path CopyCore --disable-automatic-resolution— 184 tests passed