Add optional clipboard capture sounds - #3
Conversation
The two bundled WAVs are gone. Both source licences (Pixabay and Mixkit) forbid handing their audio over as a standalone file, and a file committed to a public repository is downloadable on its own, so shipping them from a GPL-3.0 tree was a licence its own terms could not carry. `NSSound(named:)` reaches the sounds macOS already ships, which costs nothing in the bundle and follows the listener's output device and alert volume. Pop and Tink stand in for Bubble and Click; adding another is one case in the enum. That also removes SOUND_LICENSES.md, which XcodeGen was sweeping into Contents/Resources and shipping inside the app. Drops the notification hop. `copyToClipboard` calls the player directly, so the player no longer reads UserDefaults.standard behind SettingsStore's back to answer an event, and nothing has to be woken early to listen. Restores the Shelf Size picker to .segmented. It was changed to .menu in passing and has nothing to do with sound.
d0845d8 to
6a9774e
Compare
|
Off by default was the right instinct, and documenting the audio sources with hashes is more care than most people take. That care is also what surfaced the problem. I rebased and pushed one commit with four changes:
Builds clean, bundle verified free of stray resources. Merging. |
What changed
Testing
swift test --package-path CopyCore --disable-automatic-resolution— 184 tests passedIntegration note
This PR and #1 build independently. A small successful-copy notification added to #1 connects shelf Cmd+C to this optional feedback while preserving the clipboard monitor own-write suppression.