Improve shelf image previews and timestamp layout - #2
Merged
Conversation
`imageFileURL` asked the file system for each URL's content type from inside `PreviewPane.body`, so every re-render repeated the probe and a network share or a sleeping disk could block the shelf for as long as the volume took to answer. The probe now runs in a detached task keyed on the card, and the pane shows the spinner `FileImagePreview` already uses while it waits, so the generic file icon never flashes before the image. Also records why `ImageFileDetection` stays uncached: the UTType lookup measures 2.2 us per call, and a memo table would need a lock because a DatabasePool calls the SQL function from several readers at once.
Owner
|
Thanks, this one is the strongest of the four. The tests are exactly what I would have asked for, and registering the SQL function through I pushed one commit to the branch rather than sending you back and forth:
Two things I checked and deliberately left alone:
Builds clean, 187 tests pass. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Testing
git diff --checkpasses