Skip to content

fix: use site LUID across site endpoints#38

Merged
teesofttech merged 3 commits into
feature/auth-client-foundationfrom
feature/site-luid-endpoints
Jun 14, 2026
Merged

fix: use site LUID across site endpoints#38
teesofttech merged 3 commits into
feature/auth-client-foundationfrom
feature/site-luid-endpoints

Conversation

@teesofttech

Copy link
Copy Markdown
Owner

Summary

  • move DataSource, Permission, Project, User, and Group services onto the shared Tableau request builder
  • build all site-scoped REST URLs with the signed-in site LUID instead of SiteContentUrl
  • forward cancellation tokens through the migrated service APIs
  • add regression tests proving migrated services use /sites/{site-luid}/... and send X-Tableau-Auth

Validation

  • dotnet build TableauSharp.sln
  • dotnet test TableauSharp.sln
  • rg -n "SiteContentUrl|/sites/|sites/" src/TableauSharp

Stacked on #37 because this uses the auth/client foundation request builder.

Closes #22

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 96515527-1297-4a8c-bf19-46a8692e96d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/site-luid-endpoints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@teesofttech
teesofttech marked this pull request as ready for review June 14, 2026 18:28
Copilot AI review requested due to automatic review settings June 14, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…lish

fix: publish Tableau multipart content
@teesofttech
teesofttech merged commit 562c45d into feature/auth-client-foundation Jun 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants