Skip to content

chore(deps): update microsoft.build to 18.10.1 - #6772

Closed
thomhurst wants to merge 1 commit into
mainfrom
renovate/microsoft.build
Closed

thomhurst wants to merge 1 commit into
mainfrom
renovate/microsoft.build

Conversation

@thomhurst

@thomhurst thomhurst commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Type Update Change
Microsoft.Build (source) nuget minor 18.9.6 → 18.10.1
Microsoft.Build.Framework (source) nuget minor 18.9.6 → 18.10.1
Microsoft.Build.Utilities.Core (source) nuget minor 18.9.6 → 18.10.1

Release Notes

dotnet/msbuild (Microsoft.Build)

v18.10.1

What's Changed
New Contributors

Full Changelog: dotnet/msbuild@v18.9.6...v18.10.1


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Sep 10, 2026
@thomhurst
thomhurst enabled auto-merge (squash) September 10, 2026 16:16

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T20:19:28.310394Z 88de203 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 735b5c49-2905-4f2c-8dac-32feee2389fd

📥 Commits

Reviewing files that changed from the base of the PR and between a487526 and c79a7bb.

📒 Files selected for processing (1)
  • Directory.Packages.props

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates Microsoft Build packages to 18.10.1 and Verify packages to 32.0.1 across central package management, benchmark, task, and test project files.

Changes

Package version alignment

Layer / File(s) Summary
Update package versions
Directory.Packages.props, benchmarks/TUnit.SourceGenerator.Benchmarks/TUnit.SourceGenerator.Benchmarks.csproj, src/TUnit.Mocks.InternalsAccess.Tasks/TUnit.Mocks.InternalsAccess.Tasks.csproj, tests/TUnit.Mocks.InternalsAccess.Tests/TUnit.Mocks.InternalsAccess.Tests.csproj
Updates Microsoft Build packages to 18.10.1 and Verify packages to 32.0.1. The task project keeps runtime assets excluded.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: mvanhorn

Merge Risk: ⚪ Minimal · up to c79a7

This dependency-only update introduces no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the Microsoft.Build dependency update to version 18.10.1, which matches the main pull request objective.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate/microsoft.build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the package trail
Build numbers hop without fail
Verify follows, neat and bright
Projects align from left to right
The changelog rests beneath moonlight

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11d280189d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<PackageReference Include="BenchmarkDotNet" />
<PackageReference Include="Microsoft.Build" VersionOverride="18.9.6" ExcludeAssets="runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build.Framework" VersionOverride="18.9.6" ExcludeAssets="runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build" VersionOverride="18.10.1" ExcludeAssets="runtime" PrivateAssets="all" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep StringTools aligned with Microsoft.Build

When restoring TUnit.slnx, which includes this benchmark project, Microsoft.Build 18.10.1 requires Microsoft.NET.StringTools 18.10.1, but the project still directly pins StringTools to 18.9.6 on line 15. NuGet's direct-dependency-wins rule therefore selects the older version and reports a package-downgrade error (NU1605), preventing the solution from restoring; update the StringTools override alongside the other MSBuild packages.

Useful? React with 👍 / 👎.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR does not appear safe to merge because the benchmark project still targets net10.0 while its upgraded Microsoft.Build packages lack compatible compile assets.

Findings

  1. P1 Incompatible benchmark dependencies ▶

Summary

Updates the Microsoft.Build package family from 18.9.6 to 18.10.1 across central package management, benchmarks, the internals-access task, and its tests.

  • Keeps the Microsoft.Build, Framework, and Utilities package versions aligned.
  • Retains compile-time-only/runtime-host asset exclusions where previously configured.

Reviews (67) · Last reviewed commit: "chore(deps): update microsoft.build to 1..."

@thomhurst
thomhurst force-pushed the renovate/microsoft.build branch from c79a7bb to 6b93c1a Compare September 12, 2026 02:41
@thomhurst
thomhurst force-pushed the renovate/microsoft.build branch from 6b93c1a to 2467451 Compare September 12, 2026 09:13
@thomhurst
thomhurst force-pushed the renovate/microsoft.build branch from 2467451 to 39ffaf1 Compare September 12, 2026 09:36
@thomhurst
thomhurst force-pushed the renovate/microsoft.build branch from 39ffaf1 to cc1c548 Compare September 12, 2026 10:11
Comment on lines +13 to +14
<PackageReference Include="Microsoft.Build" VersionOverride="18.10.1" ExcludeAssets="runtime" PrivateAssets="all" />
<PackageReference Include="Microsoft.Build.Framework" VersionOverride="18.10.1" ExcludeAssets="runtime" PrivateAssets="all" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Incompatible benchmark dependencies

This project targets net10.0, but Microsoft.Build 18.10.1 provides only net11.0 and net472 compile assets. Neither asset is compatible with this project, so it can no longer restore or build using the compatible net10.0 asset that 18.9.6 provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

8 similar comments
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing: Microsoft.Build 18.10.x ships only net11.0/net472 runtime assets, so the net10.0 InternalsAccess tests can't load it. Pinning only some projects to 18.9.6 fails restore with NU1605. Renovate is now capped below 18.10.0 until we target net11.0 (see the linked renovate PR).

This branch had an error being deployed

1 failed deployment
Pull Requests — 88de203c Deployed Sep 22, 2026 by thomhurst via modularpipeline (ubuntu-latest) #19455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants