chore(renovate): cap Microsoft.Build packages below 18.10.0 - #6863
Conversation
18.10.x ships only net11.0/net472 runtime assets, so net10.0 consumers (e.g. TUnit.Mocks.InternalsAccess.Tests) fail to load it. See #6772.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Renovate configuration now restricts four Microsoft packages to versions below 18.10.0. The rule prevents upgrades to versions with only net11.0 and net472 runtime assets. ChangesPackage Version Guard
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The package guard is narrowly scoped and presents no actionable merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit guards the package gate Comment |
Code Review: PR #6863 — cap Microsoft.Build packages below 18.10.0Scope: Single 12-line addition to Verification performed:
Result: No correctness, design, or maintainability issues found. This is a well-scoped, low-risk config change consistent with its stated rationale and the existing pins/comments elsewhere in the repo. Approving. |
Microsoft.Build 18.10.x ships only net11.0/net472 runtime assets, so net10.0 consumers such as
TUnit.Mocks.InternalsAccess.Testscan't load it (23 tests fail withFileNotFoundException). Pinning only some projects to 18.9.6 then fails restore with NU1605.This caps the Microsoft.Build family below 18.10.0 until the repo targets net11.0. Supersedes #6772.
Summary by CodeRabbit