Repository navigation
fix: hold a WebSocket close behind delayed frames, batch reports, hide wrapper internals - #21
Merged
Merged
Conversation
…e wrapper internals
This was referenced Oct 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the minor follow-ups listed in #20.
closefirst and the frames were dropped. Thecloseevent is now held until those frames are delivered, then re-dispatched with the samecode,reasonandwasClean. Like the frames, the re-dispatched event hasisTrusted === false, andreadyStateis alreadyCLOSEDwhile the last frames arrive. Frames waiting to be sent are still dropped: the socket is gone.WeakMap/WeakSet.window.__networkOverridesWsWrapperstays (the background needs it to clear rules) but is no longer enumerable.Not done, on purpose:
alert()is open —Runtime.evaluatecannot run under a dialog; nothing short of dismissing the page's dialog fixes it;Tests
npm test186/186 (5 new),npm run lintclean,npm run smoke16/16,node scripts/e2e-websocket.mjsOK on Chromium.🤖 Generated with Claude Code