Backport #3914: fix(world): accept lazy terminal run data - fix Zod schema for newer versions - #3939
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Signed-off-by: Shalabh Chaturvedi <shalabh.chaturvedi@vercel.com>
🦋 Changeset detectedLatest commit: ef3ca7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
There was a problem hiding this comment.
Additional Suggestion:
A completed workflow run with an unmaterialized (undefined) output passes schema validation but crashes with a cryptic devalue Error('Invalid input') when hydrated, because the completed branch of pollReturnValue was not hardened for lazy terminal data like the failed branch was.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #3914 to
stable(backport job run).AI recommendation: This is a narrow correctness fix to
WorkflowRunSchemainpackages/world/src/runs.ts, which exists onstablewith the identical requiredoutput/errorkeys for the completed/failed variants, and the lazy (remoteRefBehavior: 'lazy') run responses that omit those payloads are also already present onstable(packages/world-vercel/src/runs.ts). Without it, terminal runs returned as remote refs fail validation under Zod's 4.4+ required-object-property semantics, so the change keeps the maintenance line parsing valid World responses rather than adding any capability. It ships as apatchchangeset plus a test, with no dependency onmain-only APIs.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.