refactor(oxc): relocate DevTools client into src/app to match rolldown/vite - #424
Merged
Conversation
…n/vite Move the oxc Nuxt SPA from packages/oxc/client/ to packages/oxc/src/app so oxc shares the same layout as the other analyzer UIs and can be built with `nuxi ... src` + tsdown from a single package, dropping the nested client package.json. This is PR A of the oxc UI-stack migration (plan 018); it is a pure relocation and still runs on @nuxt/ui — the UnoCSS/@vitejs/devtools-ui swap follows in later PRs. Static output now lands in dist/public (from dist/client/public) and the node dts build is decoupled from the app-inclusive root tsconfig. Adds plan 018 documenting the full migration (PRs A/B/C) and the locked decisions behind it.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relocates the oxc DevTools Nuxt SPA from
packages/oxc/client/topackages/oxc/src/app, so oxc shares the same package layout as the other analyzer UIs (rolldown,vite) and builds from a single package withnuxi … src+tsdown. This is a pure relocation — the client still runs on@nuxt/ui; the UnoCSS /@vitejs/devtools-uiswap follows in later PRs.PR A of the oxc UI-stack migration documented in
plans/018-oxc-ui-unocss-migration.md.What changed:
git mvapp/,modules/,public/,nuxt.config.ts,tsconfig.jsonintosrc/(history preserved; all app→node relative imports survive as both trees sit at the same depth underpackages/oxc).client/{package.json,tsdown.config.ts,.oxlintrc.json,.oxfmtrc.json}(the oxc-configs were byte-identical to the package-root ones).nuxt.config.ts:srcDir: 'app'; static outputdist/client→dist(client now lands indist/public).dirs.ts:clientPublicDir→dist/public.package.jsonscripts adopt the rolldown/vite shape (build: nuxi build src && tsdown,dev,dev:prepare).tsdown.config.ts:clean:false(so tsdown doesn't wipe the nuxi-built client) +tsconfig: ../../tsconfig.base.json; roottsconfig.jsonnarrowed to node-only paths.plans/README.mdrow.Linked Issues
Additional context
Verified with
pnpm turbo run build --filter=@vitejs/devtools-oxc(client prerendered todist/public, node entries emitted by tsdown) andpnpm -C packages/oxc lint. Reviewers: the diff is dominated by history-preserving renames; the substantive changes are the 4 config files (package.json,nuxt.config.ts,tsconfig.json,tsdown.config.ts) +src/dirs.ts.This PR was created with the help of an agent.