Skip to content

Maintenance patch and fixes - #5

Open
zyadsober1 wants to merge 3 commits into
wael34218:masterfrom
zyadsober1:zyad-patch-1
Open

Maintenance patch and fixes#5
zyadsober1 wants to merge 3 commits into
wael34218:masterfrom
zyadsober1:zyad-patch-1

Conversation

@zyadsober1

Copy link
Copy Markdown

* Smaller JSON dump output using separators

If specified, separators should be an (item_separator, key_separator) tuple. The default is (', ', ': ') if indent is None and (',', ': ') otherwise. To get the most compact JSON representation, you should specify (',', ':') to eliminate whitespace.

https://docs.python.org/2/library/json.html#json.dump
https://docs.python.org/3/library/json.html#json.dump


* Changed the test's URLs from https://swapi.co to https://swapi.dev

Change note from the devs: https://swapi.dev/about


* Removed warning about PyYAML load not specifying a loader

Use of PyYAML's yaml.load function without specifying the Loader=... parameter, has been deprecated. In PyYAML version 5.1+, you will get a warning, but the function will still work.

https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant