Skip to content

Maintenance patch and fixes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zyadsober1 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Maintenance patch and fixes #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d11663
feat: smaller json dump output
zyadsober1 Jan 4, 2021
3c03d55
fix: Changed https://swapi.co to https://swapi.dev (https://swapi.dev…
zyadsober1 Jan 4, 2021
5765cac
chore: Specified the PyYaml Loader to FullLoader to remove the deprec…
zyadsober1 Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi_generator/openapi_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def export(self, filename, extension="json"):
"""
if extension == "json":
with open(filename, 'w') as output_file:
json.dump(self.configs, output_file)
json.dump(self.configs, output_file, separators=(",", ":"))
elif extension == "yaml":
with open(filename, "w") as output_file:
output_file.write(yaml.dump(self.configs, default_flow_style=False))
Expand Down
10 changes: 5 additions & 5 deletions openapi_generator/test_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@

class TestOpenapiGenerator(unittest.TestCase):
def test_yaml_schema(self):
gen = OpenapiGenerator("Title", "Testing description", "0.0.1", "https://swapi.co")
response = requests.get("https://swapi.co/api/planets/", params={"page": 2})
gen = OpenapiGenerator("Title", "Testing description", "0.0.1", "https://swapi.dev")
response = requests.get("https://swapi.dev/api/planets/", params={"page": 2})
gen.add_response(response)
gen.export("example.yml", extension="yaml")

with open("example.yml") as f:
spec = yaml.load(f)
spec = yaml.load(f, Loader=yaml.FullLoader)
errors_iterator = openapi_v3_spec_validator.iter_errors(spec)
self.assertEqual(len(list(errors_iterator)), 0)

def test_json_schema(self):
gen = OpenapiGenerator("Title", "Testing description", "0.0.1", "https://swapi.co")
response = requests.get("https://swapi.co/api/planets/", params={"page": 2})
gen = OpenapiGenerator("Title", "Testing description", "0.0.1", "https://swapi.dev")
response = requests.get("https://swapi.dev/api/planets/", params={"page": 2})
gen.add_response(response)
gen.export("example.json", extension="json")

Expand Down