Skip to content

incorporate ezxml into mx - #79

Merged
webern merged 2 commits into
masterfrom
do-not-consider-ezxml-a-library
Mar 31, 2020
Merged

incorporate ezxml into mx#79
webern merged 2 commits into
masterfrom
do-not-consider-ezxml-a-library

Conversation

@webern

@webern webern commented Mar 29, 2020

Copy link
Copy Markdown
Owner

Closes #76

With this, the only remaining thing that is 'special' about ezxml is that it isn't in the mx namespace, and when we refer to it we

#include "ezxml/XFactory.h"

And not

#include "mx/private/ezxml/src/public/include/XFactory.h"

We retain its sub-directory structure and #include paths because it makes it easier to port the code back-and-forth with https://github.com/webern/ezxml

However, by removing its cmake file and no longer referring to it as add_subdirectory we eliminate any issues with installing mx.

In the future we should do what #78 says, and ensure that install package works during continuous integration runs.

@p-groarke p-groarke left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, much simpler!

@webern
webern merged commit d64afd1 into master Mar 31, 2020
@webern
webern deleted the do-not-consider-ezxml-a-library branch June 20, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove install_package for ezxml

2 participants