incorporate ezxml into mx - #79
Merged
Merged
Conversation
This was referenced Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76
With this, the only remaining thing that is 'special' about ezxml is that it isn't in the
mxnamespace, and when we refer to it weAnd not
We retain its sub-directory structure and
#includepaths because it makes it easier to port the code back-and-forth with https://github.com/webern/ezxmlHowever, by removing its cmake file and no longer referring to it as
add_subdirectorywe eliminate any issues with installingmx.In the future we should do what #78 says, and ensure that install package works during continuous integration runs.