Skip to content

Assert instanceof PropertyId - #139

Merged
JeroenDeDauw merged 1 commit into
masterfrom
abc
Aug 14, 2014
Merged

Assert instanceof PropertyId#139
JeroenDeDauw merged 1 commit into
masterfrom
abc

Conversation

@thiemowmde

@thiemowmde thiemowmde commented Aug 14, 2014

Copy link
Copy Markdown
Contributor

Another tiny split from #132.

  1. Use two different strings with different lengths.
  2. Why should a method called getPropertyId not return a PropertyId?

@JeroenDeDauw

JeroenDeDauw commented Aug 14, 2014

Copy link
Copy Markdown
Contributor

Why should a method called getPropertyId not return a PropertyId?

This test was written when we only had EntityId

JeroenDeDauw added a commit that referenced this pull request Aug 14, 2014
@JeroenDeDauw
Merge pull request #139 from wmde/abc
134beb8 
Assert instanceof PropertyId
@JeroenDeDauw
JeroenDeDauw merged commit 134beb8 into master Aug 14, 2014
@JeroenDeDauw
JeroenDeDauw deleted the abc branch August 14, 2014 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thiemowmde @JeroenDeDauw