Test if getHash is static - #132
Closed
thiemowmde wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!
This was referenced Aug 13, 2014
Merged
Contributor
|
@thiemowmde sad kittens are sad |
Contributor
Author
|
Never got an answer to my last question. Seems it's fine to break all our hashing from time to time. If you ask me it's not better if all hashes break because we reimplement the hash function or if they break because of a namespace change. The later is much more unlikely at this point in time. Coming up with a new hash function will break everything for sure. Just keeping the hash functions as they are will not break anything. Therefor I'm closing this now. |
This was referenced Oct 14, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #130.
It turns out PHP's
serialize()function just calls the...->serialize()methods provided by theSerializableinterface inSnak. See the implementations inSnakObject::serializeandPropertyValueSnak::serialize. Only properties that are used in these methods become part of the serialization.This patch:
getHashimplementation is static and doesn't change, e.g. when new fields are introduced.No- andSomeValueSnak.