Test all three SnakObject classes

tests/unit/Snak/PropertyNoValueSnakTest.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Wikibase\Test\Snak;
+
+use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Snak\PropertyNoValueSnak;
+
+/**
+ * @covers Wikibase\DataModel\Snak\PropertyNoValueSnak
+ *
+ * @group Wikibase
+ * @group WikibaseDataModel
+ * @group WikibaseSnak
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class PropertyNoValueSnakTest extends SnakObjectTest {
+
+	public function constructorProvider() {
+		return array(
+			array( true, new PropertyId( 'P1' ) ),
+			array( true, new PropertyId( 'P9001' ) ),
+		);
+	}
+
+	public function getClass() {
+		return 'Wikibase\DataModel\Snak\PropertyNoValueSnak';
+	}
+
+	/**
+	 * This test is a safeguard to make sure hashes are not changed unintentionally.
+	 */
+	public function testHashStability() {
+		$snak = new PropertyNoValueSnak( new PropertyId( 'P1' ) );
+		$hash = $snak->getHash();
+
+		$expected = sha1( 'C:43:"Wikibase\DataModel\Snak\PropertyNoValueSnak":4:{i:1;}' );
+		$this->assertSame( $expected, $hash );
+	}
+
+}

tests/unit/Snak/PropertySomeValueSnakTest.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Wikibase\Test\Snak;
+
+use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Snak\PropertySomeValueSnak;
+
+/**
+ * @covers Wikibase\DataModel\Snak\PropertySomeValueSnak
+ *
+ * @group Wikibase
+ * @group WikibaseDataModel
+ * @group WikibaseSnak
+ *
+ * @licence GNU GPL v2+
+ * @author Thiemo Mättig
+ */
+class PropertySomeValueSnakTest extends SnakObjectTest {
+
+	public function constructorProvider() {
+		return array(
+			array( true, new PropertyId( 'P1' ) ),
+			array( true, new PropertyId( 'P9001' ) ),
+		);
+	}
+
+	public function getClass() {
+		return 'Wikibase\DataModel\Snak\PropertySomeValueSnak';
+	}
+
+	/**
+	 * This test is a safeguard to make sure hashes are not changed unintentionally.
+	 */
+	public function testHashStability() {
+		$snak = new PropertySomeValueSnak( new PropertyId( 'P1' ) );
+		$hash = $snak->getHash();
+
+		$expected = sha1( 'C:45:"Wikibase\DataModel\Snak\PropertySomeValueSnak":4:{i:1;}' );
+		$this->assertSame( $expected, $hash );
+	}
+
+}

tests/unit/Snak/PropertyValueSnakTest.php

@@ -39,7 +39,6 @@ public function getClass() {
 
 	/**
 	 * This test is a safeguard to make sure hashes are not changed unintentionally.
-	 * @see EntityIdTest::testSerializationStability
 	 */
 	public function testHashStability() {
 		$snak = new PropertyValueSnak( new PropertyId( 'P1' ), new StringValue( 'a' ) );

tests/unit/Snak/SnakObjectTest.php

@@ -32,7 +32,7 @@ public abstract function getClass();
 	 *
 	 * @since 0.1
 	 *
-	 * @return array
+	 * @return array[]
 	 */
 	public abstract function constructorProvider();
 
@@ -114,7 +114,6 @@ public function testGetHash( Snak $snak ) {
 
 	/**
 	 * This test is a safeguard to make sure hashes are not changed unintentionally.
-	 * @see EntityIdTest::testSerializationStability
 	 */
 	public abstract function testHashStability();