Test all three SnakObject classes - #241
Merged
Merged
Conversation
Contributor
|
This actually tests nothing relevant in the classes but only adds duplication. The only method one can test in |
Contributor
Author
|
Ok, you are right, but if #243 gets merged first then I will rebase this and you will see why it's needed. |
thiemowmde
force-pushed
the
testAllClasses
branch
from
October 14, 2014 19:40
ff51e24 to
2502448
Compare
Contributor
Author
|
Rebased. Code duplication instead of inheritance. Are you happy now? |
Contributor
Author
There was a problem hiding this comment.
Copy & paste error. Thanks for fixing.
JeroenDeDauw
added a commit
that referenced
this pull request
Oct 14, 2014
Test all three SnakObject classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all
SnakObjectTesttests are run with all threeSnakObjectsubclasses. Currently these tests run only once for thePropertyValueSnaksubclass.This is split from #132.