fix(catalog): accept entity ids in texture setup contracts - #243
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
One blocking contract-scope issue.
|
Follow-up for opy-rs#330: the canonical catalog fix now includes EntityId acceptance for Start Forcing Dummy Bot Name, First Of, String Split, and String Replace; Boolean String Slice counts; Boolean Create Dummy Bot slots; and preservation of Empty Array split separators. Owner validation passed full workspace tests, catalog check, fmt, and clippy. Latest owner commit: 8493e8a. |
Teakowa
left a comment
There was a problem hiding this comment.
Previous blocking finding remains unresolved: the latest patch still widens String Replace Search to EntityId and the regression still invents an EntityId Search value. The two new follow-up changes (boolean Create Dummy Bot slot and preserving Empty Array as the split separator) are consistent with the pinned OverPy output and do not add another blocker. Please either provide an independent Workshop/reference case for EntityId Search or revert only that Search widening and make the regression match the pinned output.
Keep EntityId support limited to the replacement value and align the regression with the pinned Workshop shape.
…tract # Conflicts: # crates/workshop-rs/src/catalog/data/catalog.json # crates/workshop-rs/tests/identity.rs
|
Addressed the blocking review finding in 2a28990 and pushed with merge-base update 60d6d8a.
Ready for re-review. |
Summary
EntityIdinStart Forcing Dummy Bot NameandFirst Ofwhere the pinned OverPy texture setup usesLast Created EntityString Slice(..., True)Context
opy-rs#330 is lowering a pinned OverPy 9.7.10 texture/entity setup. The owner-side catalog previously rejected the pinned
Last Created Entityand boolean slice-count forms, preventing native semantic-WIR comparison.Refs wrightkit/opy-rs#330