fix(catalog): accept False/True for the Create Dummy Bot slot - #287
Merged
Merged
Conversation
Restore the falseAsNumber/trueAsNumber coercions on the slot parameter so the optimizeForSize spelling OverPy writes normalizes to the same WIR as 0/1, like every other Number|Boolean slot. Fixes #282
Teakowa
requested changes
Sep 25, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Two required pieces from the current implementation contract (#286 / ADR-0014) are missing:
catalog.json: the new positional coercion has no source citation/source-attribution update. #286 requires the fact to cite the observed pinned-reference emission, and the catalog source-attribution contract says dataset changes update the owning source attribution/provenance surface.contextual_semantics.rs: the new regression proves parse/normalization + canonical validation, but not the acceptance criterion thatFalse/Trueround-trip through emission. Add an emission/reparse round-trip assertion for thecreateDummyBotslot case.
Also retarget the PR from the now-duplicate #282 to #286 so the PR closes the actual implementation owner.
Record the observed optimizeForSize emission in the catalog source attribution and add an emit/reparse assertion for the False/True slot case (#286).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286
Summary
falseAsNumber/trueAsNumberon thecreateDummyBotslot (keeping theNumber|Booleantype from fix(catalog): accept entity ids in texture setup contracts #243), so OverPy'soptimizeForSizespelling (False/True) normalizes to the same WIR as0/1.canReplace0ByFalse/canReplace1ByTrueparameter against the catalog; this was the only Number parameter missing the coercions.Verification
cargo fmt,clippy -D warnings,cargo test --workspace --all-targets,workshop-catalog-gen checkpass.createDummy42/42 match (2 differed before);catalog-missing-coercionmatches 0 probes.Follow-up
opy-rs must bump workshop-rs and remove
catalog-missing-coercionfromprobe-gaps.json.