Skip to content

feat(localization): complete Workshop locale coverage - #245

Merged
Teakowa merged 1 commit into
mainfrom
codex/issue-237-locale-coverage
Sep 20, 2026
Merged

Teakowa merged 1 commit into
mainfrom
codex/issue-237-locale-coverage

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • extend the canonical catalog and generated settings projection to the pinned 15-locale OverPy 9.7.10 set
  • preserve strict provenance, exclusions, fallback reporting, and real-project round trips
  • support localized Unicode syntax and primary-locale-aware detection

Verification

  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace --all-targets
  • workshop-catalog-gen check
  • independent ablation: removing the fr-FR setGlobalVariable mapping makes the all-locale conversion regression fail

Refs #237

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Fixes #237 would auto-close #237 when this PR merges, but #237's acceptance criteria require a released workshop-rs version exposing the completed locale contract. Keep #237 open (for example, use Refs #237) until that release exists.

Comment thread crates/workshop-rs/src/frontend/lexer.rs
Extend the canonical catalog and settings projection to the pinned 15-locale OverPy 9.7.10 set, preserve strict provenance and fallback behavior, and make parsing and detection work with localized Unicode syntax.

Refs #237
@e54-bot
e54-bot force-pushed the codex/issue-237-locale-coverage branch from 294cb75 to b0adb4c Compare September 20, 2026 10:32
@Teakowa
Teakowa merged commit 567bf98 into main Sep 20, 2026
5 checks passed
@Teakowa
Teakowa deleted the codex/issue-237-locale-coverage branch September 20, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants