feat: add SourceMap and canonical mapped Workshop artifact - #274
Merged
Merged
Conversation
Define workshop-rs/text-v1 and workshop-rs/mapped-text-v1, a public SourceMap that extracts from a span-bearing Program and applies to a Program parsed from the same text, and a shape guard so span accessors return None after rules, conditions, or actions are inserted or removed. Fixes #272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Summary
Noneafter rules, conditions, or actions are inserted or removed.SourceMap(extract/apply) andMappedText, definingworkshop-rs/mapped-text-v1(JSON: text, file table, shape, position-keyed spans).workshop-rs/text-v1is plain Workshop text.applyrejects the whole mapping with a typedSourceMapErroron shape mismatch or invalid entries; the program is left unchanged.docs/source-preservation.md,docs/compatibility-facades.md, and rustdoc.Notes
Test plan
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets(real-project extract → emit → parse → apply round trip, shape mismatch, drift, non-ASCII columns)workshop-catalog-gen check,git diff --checkcargo semver-checks: additive