fix: reject duplicate and empty source map entries - #276
Merged
Merged
Conversation
Address review findings: SourceMap::apply now rejects duplicate node entries and declaration entries without a span. Document that apply drops retained source documents, that spans may be empty, and that decoders ignore unknown members; amend ADR-0013 for the declaration counts in the shape. Refs #272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #274 (implements #272), carrying review fixes that landed on the branch after the merge.
Summary
SourceMap::applyrejects duplicate node entries (DuplicateEntry) and declaration entries with neitherspannorname_span(EmptyEntry); both were previously accepted silently.applydrops retained source documents,spansmay be empty, decoders ignore unknown members.Behavior of attaching after shape drift is unchanged.
Test plan
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets(new duplicate/empty-entry tests)git diff --check