fix(catalog): use OverPy zh-CN spellings for Break and Is Firing Secondary - #295
Merged
Merged
Conversation
…ndary The zh-CN spelling 中断 is Break in the pinned OverPy 9.7.10 emission and the locale corpus, but the catalog treated it as an Abort alias and named Break 跳出循环. Make 中断 the Break spelling and keep 跳出循环 as a parse alias. Use 正在使用辅助武器 as the Is Firing Secondary spelling, moving it off the isFiringSecondaryFire identity, and keep 正在发射辅助攻击 as a parse alias. Bastion compiled through Wright previously emitted 跳出循环 and 正在发射辅助攻击 where OverPy emits 中断 and 正在使用辅助武器.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by re-running the Bastion build diff (Wright 0.2.36 vs pinned OverPy 9.7.10, zh-CN):
中断forbreak. The catalog treated中断as an Abort alias and named Break跳出循环, so Bastion's onlybreakcame out as跳出循环via Wright and as中止(Abort) after a workshop-rs re-emit of the OverPy output.正在使用辅助武器for Is Firing Secondary; the catalog held that spelling on theisFiringSecondaryFireidentity and namedisFiringSecondary正在发射辅助攻击.Changes:
中断is Break's spelling (跳出循环kept as a parse alias);正在使用辅助武器is Is Firing Secondary's spelling (正在发射辅助攻击kept as a parse alias) and is removed fromisFiringSecondaryFire, which now has no zh-CN spelling. The old alias-conflict test is replaced by tests for the new mapping; digest pin and source attribution updated.Verification: fmt, clippy, workspace tests,
workshop-catalog-gen checkpass. With this change patched into Wright, Bastionmain.opy(zh-CN) compiled by Wright vs OverPy differs canonically by one line (开始限制阈值假vs0, unrelated); before it was four differing lines.