Sort Xcode version by most recent#393
Conversation
This prevents installing a GM or Beta version if the final version is already published.
f8e6a0c to
0d89123
Compare
0d89123 to
e8ca92a
Compare
06599d0 to
62f9898
Compare
|
This is finally green 🟢 |
|
Thanks for doing this @pietbrauer - would love to see it merged. This caused issues for us when upgrading our CI farm to 11.5. |
|
@justindhill Thanks! Did you try it out and could confirm that it works for you, too? |
|
@pietbrauer I tested and it works as expected, thanks so much for working on this. @joshdholtz Could we pretty please find a way to merge and release this soon? Right now if I try to install a non beta version of Xcode i.e. Happy to help in any way I can. Thanks |
|
Yeah yeah! Pulling laptop out now to test and then I’ll merge and push out a new version! Will try to get it out by EOD 💪 |
joshdholtz
left a comment
There was a problem hiding this comment.
This is great! Thank you ❤️ I will get a new build pushed out right away
This prevents installing a GM or Beta version if the final version is already published.
The date parsing was also broken. The API returns "05/20/20 11:45" this would result in
to_ibeing11which I found useless.The only tests failing are the ones for the scraping. Are those needed anymore? Beta and GMs are included in the JSON. I am not sure on how to update the fixtures.