Skip to content

Sort Xcode version by most recent#393

Merged
joshdholtz merged 6 commits into
xcpretty:masterfrom
pietbrauer:sort-by-most-recent
Jun 13, 2020
Merged

Sort Xcode version by most recent#393
joshdholtz merged 6 commits into
xcpretty:masterfrom
pietbrauer:sort-by-most-recent

Conversation

@pietbrauer

@pietbrauer pietbrauer commented May 29, 2020

Copy link
Copy Markdown
Contributor

This prevents installing a GM or Beta version if the final version is already published.

The date parsing was also broken. The API returns "05/20/20 11:45" this would result in to_i being 11 which I found useless.

The only tests failing are the ones for the scraping. Are those needed anymore? Beta and GMs are included in the JSON. I am not sure on how to update the fixtures.

This prevents installing a GM or Beta version if the final version is already published.
@pietbrauer
pietbrauer force-pushed the sort-by-most-recent branch from 06599d0 to 62f9898 Compare June 2, 2020 08:08
@pietbrauer

Copy link
Copy Markdown
Contributor Author

This is finally green 🟢

@justindhill

Copy link
Copy Markdown

Thanks for doing this @pietbrauer - would love to see it merged. This caused issues for us when upgrading our CI farm to 11.5.

@pietbrauer

Copy link
Copy Markdown
Contributor Author

@justindhill Thanks! Did you try it out and could confirm that it works for you, too?

@rpassis

rpassis commented Jun 12, 2020

Copy link
Copy Markdown

@pietbrauer I tested and it works as expected, thanks so much for working on this.

@joshdholtz Could we pretty please find a way to merge and release this soon? Right now if I try to install a non beta version of Xcode i.e. xcversion install 11.5 it will silently install the beta version with no indication that this is the case (other than the build version mismatch at the end of the installation).

Happy to help in any way I can.

Thanks ♥️

@joshdholtz

joshdholtz commented Jun 12, 2020

Copy link
Copy Markdown
Member

Yeah yeah! Pulling laptop out now to test and then I’ll merge and push out a new version!

Will try to get it out by EOD 💪

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you ❤️ I will get a new build pushed out right away

@joshdholtz
joshdholtz merged commit 8ac1ed3 into xcpretty:master Jun 13, 2020
@pietbrauer
pietbrauer deleted the sort-by-most-recent branch June 13, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants