Skip to content

fix: avoid idle workspace re-renders from activity and label churn - #186

Merged
kalvinnchau merged 1 commit into
mainfrom
am/idle-workspace-batch1
Sep 23, 2026
Merged

kalvinnchau merged 1 commit into
mainfrom
am/idle-workspace-batch1

Conversation

@kalvinnchau

Copy link
Copy Markdown
Contributor

Summary

  • Subscribe the workspace to a stable working-channel projection, preserving expiry on the existing activity timer.
  • Stabilize composer send and unchanged DM labels/session child arrays across unrelated updates.

Validation

  • Full frontend Vitest: 2,410 passed (227 files); Biome, TypeScript, and frontend build passed at the same code tree before the metadata-only amend.
  • Pre-push at 4055b1d: TypeScript, 863 related tests, and design-system guards passed (BUZZ_TEST_WORKERS=2).
  • In the S1 trace, the 58–75 s quiet window had zero workspace/sidebar/composer/row renders despite activity updates. During 39–58 s, 20 sidebar renders corresponded to actual preview changes. The 201 row renders during that burst are out of scope (batch 2). This is not a controlled before/after benchmark.

Remaining checks

  • Default-worker runs previously hit unrelated relay/read-state timeouts; bounded-worker full-suite runs passed. No fresh browser/native journey after the metadata-only amend.
  • No browser cases were added or removed.

Co-authored-by: Kalvin Chau <kalvin@block.xyz>
Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Signed-off-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>
@kalvinnchau
kalvinnchau requested review from a team, comp615 and wesbillman as code owners September 23, 2026 23:11

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

No blocking findings at 4055b1ddc7cd1809aa9df3028323d391b13333aa against base/merge-base a47ddaf452e605a59056476d2091146e1f3902e8.

Reviewed the working-channel projection through expiry, disconnect, access/cache reset and disposal; DM-label and child-session identity invalidation; and composer send/reveal/navigation behavior. Independent activity and UI review lanes returned no concrete defects. The change keeps the existing activity timer and authority boundaries, and cache reuse remains conditional on unchanged source identity and resolved values.

Hosted checks passed, including CI required, all Chromium/WebKit shards and DCO; Windows native validation was skipped. Review validation was source/diff/test inspection, not a fresh local test run or app launch. The PR’s S1 trace is useful observational evidence, not a controlled before/after benchmark. Direct regression assertions for child-array identity and working-subscriber reset notifications would strengthen coverage, but no failing behavior was established. This is a comment review, not approval or merge authorization.

@kalvinnchau
kalvinnchau merged commit 5286ed2 into main Sep 23, 2026
12 checks passed
@kalvinnchau
kalvinnchau deleted the am/idle-workspace-batch1 branch September 23, 2026 23:28
zrmarley added a commit that referenced this pull request Sep 24, 2026
…o-player-polish

* origin/main: (38 commits)
  Fix diff content fallback, keyboard scrolling and edit selection (#205)
  Standardize form controls and field feedback across Buzz (#174)
  Keep image review downloads and external opens distinct (#144)
  Verify media review comments (#166)
  Follow system appearance (#210)
  Add rich composer formatting and spoiler rendering (#203)
  feat: show roster-backed channels and managed instances in profiles (#188)
  Add new direct message flow (#156)
  Remove Home, start in Messages, and keep Channels enabled (#194)
  fix: restore avatar presence controls and active-input sensing (#198)
  Add legacy diff messages with inline and expanded viewing (#202)
  Edit the latest own message with Up in the existing composer (#192)
  Add complete reaction toggles to the message menu (#185)
  feat: add persistent community navigation rail (#191)
  test: add margin to warm-switch performance gate (#195)
  Add composer attachments and compatible media preparation (#183)
  Add reply and copying to the shared message menu (#182)
  fix: avoid idle workspace re-renders from activity and label churn (#186)
  feat: add devtools trace capture to web profiling (#180)
  Add optional channel templates, teams and personal group defaults (#181)
  ...

Signed-off-by: Zach Marley <zmarley@squareup.com>
zrmarley added a commit that referenced this pull request Sep 24, 2026
…-content-compat

* origin/main: (38 commits)
  Fix diff content fallback, keyboard scrolling and edit selection (#205)
  Standardize form controls and field feedback across Buzz (#174)
  Keep image review downloads and external opens distinct (#144)
  Verify media review comments (#166)
  Follow system appearance (#210)
  Add rich composer formatting and spoiler rendering (#203)
  feat: show roster-backed channels and managed instances in profiles (#188)
  Add new direct message flow (#156)
  Remove Home, start in Messages, and keep Channels enabled (#194)
  fix: restore avatar presence controls and active-input sensing (#198)
  Add legacy diff messages with inline and expanded viewing (#202)
  Edit the latest own message with Up in the existing composer (#192)
  Add complete reaction toggles to the message menu (#185)
  feat: add persistent community navigation rail (#191)
  test: add margin to warm-switch performance gate (#195)
  Add composer attachments and compatible media preparation (#183)
  Add reply and copying to the shared message menu (#182)
  fix: avoid idle workspace re-renders from activity and label churn (#186)
  feat: add devtools trace capture to web profiling (#180)
  Add optional channel templates, teams and personal group defaults (#181)
  ...

Signed-off-by: Zach Marley <zmarley@squareup.com>

# Conflicts:
#	docs/channels.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants