Skip to content

Remove Home, start in Messages, and keep Channels enabled - #194

Merged
morgmart merged 8 commits into
mainfrom
morganm/hide-home
Sep 24, 2026
Merged

morgmart merged 8 commits into
mainfrom
morganm/hide-home

Conversation

@morgmart

@morgmart morgmart commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

What this does

Removes Home and makes Messages the default destination. Home no longer appears in tabs, search, or error actions. Old Home links still open Messages without flashing the deleted page or adding a back-button step.

Channels is permanently enabled across browser, desktop, and CLI management. Previously saved “disabled” preferences no longer disable it, and Settings has no Channels switch. Other plugins retain their normal controls.

Implementation boundaries

  • Deletes the Home component and launch flag, rather than retaining a hidden feature or alternate build.
  • Retains the legacy version-1 Home navigation target for compatibility. It resolves to Messages before paint within the same navigation attempt and visit, preserving cancellation, history, and stale-completion protection.
  • Enforces required Channels in both the browser storage adapter and native plugin manager, not just Settings. Rejected disable requests do not write preferences; old disabled values remain inert without a destructive migration. Invalid browser configuration still enters recovery.
  • Failed destinations offer Settings. Loading, failure, and plugin-configuration recovery remain available.
  • Includes the startup-order repair discovered during this PR: optional template loading begins after initial channel discovery, avoiding cancellation of the initial request. Shared cancellation and access rules are unchanged.
  • Updates existing product documentation to match the removal and required-Channels policy. No custom styling or new flag service.

Validation

Current pushed head: b910d79427acb176798e585be063b34153c40d15.

  • Mandatory push checks passed at this head: formatting/lint, sadscan, TypeScript, 254 test files / 2,622 tests, and design-system type/color/contrast/foundations/icons/adoption guards.
  • On the Home-deletion working tree before the final documentation/test cleanup, 40 browser checks passed across Chromium and WebKit using launch-home.spec.mjs appearance.spec.mjs navigation-repairs.spec.mjs navigation-lifecycle.spec.mjs --no-deps. Filename matching also selected profiles-appearance coverage.
  • Required-Channels validation before Home deletion: 40 browser checks passed across Chromium/WebKit for launch, layout, and Settings-related files. An initial WebKit profile case failed, then passed unchanged on rerun; the initial run was not clean.
  • Native plugin-manager package: 10 unit tests + 13 management tests passed. Browser/native tests cover saved-disabled preferences, reopen, rejection without writes, and independent optional-plugin controls.
  • Production app and design-system builds/typechecks passed; only large-chunk warnings were reported.
  • Independent lifecycle and coverage reviews were clear (source-only). Requested documentation and whitespace cleanup is included in the final commit.
  • Hosted DCO passed. Hosted JavaScript, Rust, browser journeys, and browser measurements were pending when checked after the push. Windows native validation was skipped.

Coverage changes and remaining gaps

The obsolete Home-enabled browser suite and its alternate build fixture are deleted. Still-relevant typography and spacing assertions moved into the regular appearance suite. Launch coverage retains no-Home-flash checks, responsive tabs/search, legacy links, reload, back/forward, required-Channels normalization, and corrupt-configuration recovery. Existing cross-page tests use optional pages where disabling/unmounting remains supported.

The startup-order regression uses an explicit discovery gate and failed before its production repair; the affected browser-file run then passed 38/38. Those historical checks are not claimed as a full-suite run at the current head.

The updated design-system viewer host-ownership browser check did not execute because its configured port 1444 was occupied. The existing server was left untouched. Native GUI/packaging smoke testing and the full browser suite have not been run locally for this head; hosted validation remains outstanding.

Earlier visual reference

This screenshot uses synthetic browser-test data and test-only plugin tabs. It predates the community rail merged from main; it is not a current-head screenshot.

Buzz opening directly into Messages with Home absent

Originating Buzz conversation: buzz://message/94b01414-b886-445f-80f0-183554fd9388/0c8a02dc0ae5fd3feb11a1960bc6a3487aa108e4ba49e63379a4d67e858e24ba

Co-authored-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
@morgmart
morgmart marked this pull request as ready for review September 24, 2026 02:06
@morgmart
morgmart requested review from a team, comp615 and wesbillman as code owners September 24, 2026 02:06
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Review clear: no actionable blockers found. Reviewed efdb0245ab51bdad60f0e9b55dbe300c006c57dd against fe897a10f1bfa6590092b0f82d943e9b555c42c3, including an independent navigation-surface review.

Home is hidden through one build-time authority, legacy/default Home targets resolve within the same visit, and Settings remains reachable through destination and configuration recovery. The template-loading repair reuses initial channel-authority readiness rather than widening shared cancellation behavior.

Existing exact-head CI passed, including 540/540 Chromium/WebKit journey cases with no flaky or skipped cases. The launch, enabled-Home and startup-template regressions passed in both engines without retries. This was source-only review; I did not execute PR code or rerun CI. Windows native validation was skipped, and native packaging/live release acceptance remains outside this verdict.

Non-blocking documentation follow-up: docs/shell-design.md still describes unconditional Home; document its launch gate when updating that page. No source fix is required by this review. This is a comment, not an approval.

Carl added 3 commits September 23, 2026 19:57
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
* origin/main:
  Add complete reaction toggles to the message menu (#185)
  feat: add persistent community navigation rail (#191)
  test: add margin to warm-switch performance gate (#195)

Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
@wesbillman

Copy link
Copy Markdown
Collaborator

We could probably just delete home completely from the codebase and re-add back whatever it is we actually want when the time comes instead of feature flagging it here

Carl added 3 commits September 23, 2026 21:14
* origin/main:
  fix: restore avatar presence controls and active-input sensing (#198)
  Add legacy diff messages with inline and expanded viewing (#202)
  Edit the latest own message with Up in the existing composer (#192)

Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
@morgmart morgmart changed the title Hide Home for launch and start in Messages Remove Home, start in Messages, and keep Channels enabled Sep 24, 2026
@morgmart
morgmart merged commit 21ea351 into main Sep 24, 2026
12 checks passed
@morgmart
morgmart deleted the morganm/hide-home branch September 24, 2026 04:50
morgmart pushed a commit that referenced this pull request Sep 24, 2026
…rs-support

* origin/main:
  Remove Home, start in Messages, and keep Channels enabled (#194)

Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
zrmarley added a commit that referenced this pull request Sep 24, 2026
…o-player-polish

* origin/main: (38 commits)
  Fix diff content fallback, keyboard scrolling and edit selection (#205)
  Standardize form controls and field feedback across Buzz (#174)
  Keep image review downloads and external opens distinct (#144)
  Verify media review comments (#166)
  Follow system appearance (#210)
  Add rich composer formatting and spoiler rendering (#203)
  feat: show roster-backed channels and managed instances in profiles (#188)
  Add new direct message flow (#156)
  Remove Home, start in Messages, and keep Channels enabled (#194)
  fix: restore avatar presence controls and active-input sensing (#198)
  Add legacy diff messages with inline and expanded viewing (#202)
  Edit the latest own message with Up in the existing composer (#192)
  Add complete reaction toggles to the message menu (#185)
  feat: add persistent community navigation rail (#191)
  test: add margin to warm-switch performance gate (#195)
  Add composer attachments and compatible media preparation (#183)
  Add reply and copying to the shared message menu (#182)
  fix: avoid idle workspace re-renders from activity and label churn (#186)
  feat: add devtools trace capture to web profiling (#180)
  Add optional channel templates, teams and personal group defaults (#181)
  ...

Signed-off-by: Zach Marley <zmarley@squareup.com>
zrmarley added a commit that referenced this pull request Sep 24, 2026
…-content-compat

* origin/main: (38 commits)
  Fix diff content fallback, keyboard scrolling and edit selection (#205)
  Standardize form controls and field feedback across Buzz (#174)
  Keep image review downloads and external opens distinct (#144)
  Verify media review comments (#166)
  Follow system appearance (#210)
  Add rich composer formatting and spoiler rendering (#203)
  feat: show roster-backed channels and managed instances in profiles (#188)
  Add new direct message flow (#156)
  Remove Home, start in Messages, and keep Channels enabled (#194)
  fix: restore avatar presence controls and active-input sensing (#198)
  Add legacy diff messages with inline and expanded viewing (#202)
  Edit the latest own message with Up in the existing composer (#192)
  Add complete reaction toggles to the message menu (#185)
  feat: add persistent community navigation rail (#191)
  test: add margin to warm-switch performance gate (#195)
  Add composer attachments and compatible media preparation (#183)
  Add reply and copying to the shared message menu (#182)
  fix: avoid idle workspace re-renders from activity and label churn (#186)
  feat: add devtools trace capture to web profiling (#180)
  Add optional channel templates, teams and personal group defaults (#181)
  ...

Signed-off-by: Zach Marley <zmarley@squareup.com>

# Conflicts:
#	docs/channels.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants