feat: add persistent community navigation rail - #191
Conversation
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Reviewed 203c95c0148a0d078a803562bd2b9ae0ea840de2 against 222605777f8808617026ea33a0aad266bdaff4c6.
Changes requested: one P2 foreground-latency regression, detailed inline. Bound optional icon discovery so unavailable saved communities cannot monopolize the broker’s browser connections, and cover foreground progress while icon responses remain gated in Chromium and WebKit.
Selection/join ownership and icon URL/security review found no additional blockers. Hosted JavaScript and completed browser checks are green; the focused local browser/HTTP probe nevertheless reproduces starvation in both engines. CI exercises synthetic merge 487be15, not the isolated source head. Native desktop and live-relay behavior remain unverified. Unread totals and community removal remain outside scope.
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Re-review: no remaining blockers. Reviewed 14325bd1ed079400d21f019648a86e27d5368012 against base 222605777f8808617026ea33a0aad266bdaff4c6, concentrating on the fix since 203c95c.
The original P2 is resolved: two bounded icon workers leave foreground connection capacity, advance after failures, and stop scheduling/updating after effect cancellation. The new real-server regression requires a browser request to reach the server and complete while icon responses remain held, then verifies all eight discovery attempts arrive after release. I independently reviewed the worker lifecycle and integrated a second review of the test’s gate/order.
Hosted artifacts confirm the new test passed in Chromium (713ms) and WebKit (1,470ms); all current required CI checks are green. CI tested synthetic merge 8c7890f6ab236566f90376cb9c1ff5d7852eb094, incorporating this head into fe897a1. Broad suites were not duplicated locally. Native desktop/live-relay behavior remains unverified, and the synthetic foreground probe is not a full-app latency benchmark.
Withdrawing the prior changes request because its exit criteria are met. This is a review result, not an approval or merge.
Carl, an automated reviewer, commenting via Wes’s GitHub account. The sole P2 is resolved at 14325bd; bounded workers and passing gated Chromium/WebKit regressions meet the original exit criteria. See the verified follow-up review. No approval or merge.
…embers-dialog * morganm/channel-members-support: feat: add persistent community navigation rail (#191) Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>
…o-player-polish * origin/main: (38 commits) Fix diff content fallback, keyboard scrolling and edit selection (#205) Standardize form controls and field feedback across Buzz (#174) Keep image review downloads and external opens distinct (#144) Verify media review comments (#166) Follow system appearance (#210) Add rich composer formatting and spoiler rendering (#203) feat: show roster-backed channels and managed instances in profiles (#188) Add new direct message flow (#156) Remove Home, start in Messages, and keep Channels enabled (#194) fix: restore avatar presence controls and active-input sensing (#198) Add legacy diff messages with inline and expanded viewing (#202) Edit the latest own message with Up in the existing composer (#192) Add complete reaction toggles to the message menu (#185) feat: add persistent community navigation rail (#191) test: add margin to warm-switch performance gate (#195) Add composer attachments and compatible media preparation (#183) Add reply and copying to the shared message menu (#182) fix: avoid idle workspace re-renders from activity and label churn (#186) feat: add devtools trace capture to web profiling (#180) Add optional channel templates, teams and personal group defaults (#181) ... Signed-off-by: Zach Marley <zmarley@squareup.com>
…-content-compat * origin/main: (38 commits) Fix diff content fallback, keyboard scrolling and edit selection (#205) Standardize form controls and field feedback across Buzz (#174) Keep image review downloads and external opens distinct (#144) Verify media review comments (#166) Follow system appearance (#210) Add rich composer formatting and spoiler rendering (#203) feat: show roster-backed channels and managed instances in profiles (#188) Add new direct message flow (#156) Remove Home, start in Messages, and keep Channels enabled (#194) fix: restore avatar presence controls and active-input sensing (#198) Add legacy diff messages with inline and expanded viewing (#202) Edit the latest own message with Up in the existing composer (#192) Add complete reaction toggles to the message menu (#185) feat: add persistent community navigation rail (#191) test: add margin to warm-switch performance gate (#195) Add composer attachments and compatible media preparation (#183) Add reply and copying to the shared message menu (#182) fix: avoid idle workspace re-renders from activity and label churn (#186) feat: add devtools trace capture to web profiling (#180) Add optional channel templates, teams and personal group defaults (#181) ... Signed-off-by: Zach Marley <zmarley@squareup.com> # Conflicts: # docs/channels.md
Summary
Screenshots
Both web images use the same 1440×950 Chromium fixture; only the left 720 px are shown. The desktop image was supplied in the originating thread.
Before (web,

a47ddaf)After (web, rail)

Desktop reference

Verification
4f2b99e: 2,474 Vitest tests; TypeScript, design checks/build; 84 Chromium/WebKit browser cases for affected layout, navigation, join, settings, scroll and unread-sidebar flows.Deferred