feat: add managed agents to channels from profiles - #196
Conversation
18d4ba3 to
1cfe4e7
Compare
1cfe4e7 to
5c57562
Compare
5c57562 to
efcbdbd
Compare
efcbdbd to
5516571
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Changes requested: one P2 recovery defect, detailed inline. A failed native refresh removes the active dialog and hides the result instead of giving the user a recovery path.
Merge criterion: preserve a visible outcome/retry surface when eligibility disappears, without weakening admission checks; cover the transition with notifying stores or the real native controller.
Source-only review of 55165717b9e058a374f20e04d13fcbbbf099517c against stacked base 99e6e936b62e040b297f6c2c68889115a1dbf284, including independent UI/native review and coordinator verification. Existing exact-head CI passed its required gate and both browser engines; Windows native validation was skipped. No local tests or PR code execution. Live native-to-relay authorization, packaged behavior and actual restart recovery remain unverified.
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
Focused re-review: the prior native-refresh recovery blocker is resolved; no new blocking defects found in the changed paths. The open dialog now retains its failure/retry surface while current eligibility still fences admission. The notifying-store regression covers failure, disabled submission, native recovery and explicit resubmission. One non-blocking documentation clarification is inline; the unchanged ordinary-composer path is not being certified as guarded by this re-review.
Reviewed 9153501f8e618fbd84517fafda95ab918ded9a51 against stacked base 99e6e936b62e040b297f6c2c68889115a1dbf284, focusing on the two-file delta from 55165717b9e058a374f20e04d13fcbbbf099517c and its admission/native-control callers. Source-only review with independent UI/native recovery analysis; no PR code or tests executed. Existing exact-head CI passed its required gate and Chromium/WebKit journeys. Windows native validation was skipped; live native-to-relay authorization, packaged behavior and actual durable restart remain unverified. This is a COMMENTED review, not approval or live acceptance.
9153501 to
00b5c32
Compare
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
…itations Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
00b5c32 to
dabf31a
Compare
Co-authored-by: Kalvin Chau <kalvin@block.xyz> Signed-off-by: Kalvin Chau <kalvin@block.xyz>
…rs-support * origin/main: feat: show owner-view agent memories in profiles (#231) Add opt-in Canvas-backed channel Todos (#222) Skip hidden folders when discovering plugins in a folder (#229) feat: add owned local agent actions to profiles (#190) feat(channels): move session creation into the context menu (#209) Add Goose as an agent harness option (#214) feat: preview channel agent activity in profiles (#187) Use context-aware identity names with human-first priority (#167) feat: add managed agents to channels from profiles (#196) Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz> # Conflicts: # src/features/relay/outbox.ts
Stack
Depends on #188 (read-only profile channels). Review against
am/profile-agent-channelshead2c546f9fd55609202cff2337cdeac1bad06e3bd6to isolate admission changes.What changed
Verification
5c5756221254fb6c13c13689b88606d5f8ed7d86: production typecheck/build; three focused test files (31/31); source-fixture profile browser journeys in Chromium/WebKit (8/8); pre-push TypeScript, related unit tests (90 files, 1,218 tests) and design-system guards passed locally.Sample screenshot
Kalvin’s supplied example of the tester profile’s Add to channel row, hosted as an uncommitted GitHub attachment; no human photograph. This is an example of the feature, not proof of the final head’s live native-to-relay flow.