Skip to content

feat: show owner-view agent memories in profiles - #231

Merged
kalvinnchau merged 6 commits into
mainfrom
cid/profile-agent-memories
Sep 24, 2026
Merged

kalvinnchau merged 6 commits into
mainfrom
cid/profile-agent-memories

Conversation

@kalvinnchau

Copy link
Copy Markdown
Contributor

Changes

  • Add a lazy Memories profile tab with plain-text disclosures and recovery-only Retry.
  • Read owner-scoped encrypted memories through the development broker with signature, Unicode, head/tombstone, and size validation.
  • Clear and fence plaintext on access loss, disconnect, cache clearing, and unmount.

Validation

  • TypeScript, design guards, and 1,418 related tests pass.
  • Chromium/WebKit profile journeys: 4/4 pass. Existing cases extended for disclosure keyboard behavior and wrapping; no cases added or removed. Protocol and lifecycle matrices remain in unit tests.
  • Full Vitest passed before the final unrelated-main rebase.

Packaged/signer-only transport is unsupported. Native acceptance and rendered browser-to-live-relay coverage remain deferred.

@kalvinnchau
kalvinnchau requested review from a team, comp615 and wesbillman as code owners September 24, 2026 18:34
cid added 6 commits September 24, 2026 12:17
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
Signed-off-by: cid <d9f92a72922bf45c17379a47d64dae84b6020397c2d5a52b5317d512068cd9d3@buzz.block.builderlab.xyz>
@kalvinnchau
kalvinnchau force-pushed the cid/profile-agent-memories branch from 2d72f8d to 733225d Compare September 24, 2026 19:19

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carl, an automated reviewer, commenting via Wes’s GitHub account.

No merge-blocking code findings at 733225d7b34f2695a5afb6218e21d1116dc5b0a8 against 842c1d3bac29f42a029e383759642ef1fc6705a2. All independent review lanes are complete.

  • Traced owner-scoped broker → transport → session → lazy profile presentation, including signatures/decryption, valid heads/tombstones, plaintext retirement, failure recovery and disclosure accessibility. The rebase preserves the memory patches; the overlapping Info-tab composition was independently rechecked.
  • At this exact clean head, all 28 tests across ProfileMemories, ProfilePanel and ProfileAgentActions passed. Earlier full CI passed 2,887 Vitest tests and Chromium/WebKit profile journeys at 2d72f8d0 merged into 8842b3ac, not this new head. Independent published NIP-AE signed/encrypted vectors passed the unchanged decoder with test keys, including tombstones in both input orders.
  • Current-head CI is still pending; it remains a merge gate. No live private-memory reads were performed. Rendered browser-to-live-relay and native/cross-platform acceptance remain deferred; packaged/signer-only transport is explicitly unsupported under the accepted development-broker-only scope.

Comment-only review, not an approval. No code changes requested within this scope.

@kalvinnchau
kalvinnchau merged commit 7de4708 into main Sep 24, 2026
12 checks passed
@kalvinnchau
kalvinnchau deleted the cid/profile-agent-memories branch September 24, 2026 19:31
morgmart pushed a commit that referenced this pull request Sep 24, 2026
…rs-support

* origin/main:
  feat: show owner-view agent memories in profiles (#231)
  Add opt-in Canvas-backed channel Todos (#222)
  Skip hidden folders when discovering plugins in a folder (#229)
  feat: add owned local agent actions to profiles (#190)
  feat(channels): move session creation into the context menu (#209)
  Add Goose as an agent harness option (#214)
  feat: preview channel agent activity in profiles (#187)
  Use context-aware identity names with human-first priority (#167)
  feat: add managed agents to channels from profiles (#196)

Signed-off-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz>

# Conflicts:
#	src/features/relay/outbox.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants