test(agents): check model lookup Cancel by visible text

[loganj]

🤖

Summary

• Fixes an intermittent failure in the model picker test for Pi agents. On main and several branches it failed about one run in three.
• The test checks that a Cancel model lookup button is visible while the model list loads. While the model menu is open, the menu hides the rest of the screen from assistive technology. It does this on its own timing, so the button sometimes had no accessible name when the test looked for it by name.
• The test now waits for the "Loading Pi models…" status. Then it finds the button by its visible text and checks that the button is visible. What the test checks stays the same: Cancel is shown during the lookup.

Details

• Test-only change in src/bundled/agents/AgentModelPicker.test.tsx.
• Local evidence: 11 of 32 runs failed before the change, and 48 of 48 runs passed after it.

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

No actionable findings at head 2fcc2e9edb5a2fe43c398524f9601f72fdb5a07b against base 01523e2c1781da1cd84620e61188df6c3d365938. Comment only, not approval.

The replacement still requires the actual Cancel button to be visible while a deferred lookup is held pending. It retains the named loading-status and busy-state assertions, then verifies successful model selection. The neighboring cancellation test still finds Cancel by accessible role/name after closing the popup and exercises cancellation, late-result rejection and retry. No production change, sleeps, retries or weakened completion checks.

Hosted CI is green, including CI required. The JavaScript log confirms 9/9 picker tests and 3,788 tests across 347 files passed on synthetic merge 0f1915350787ad5f8da72656a4b24c327f272df2. Current main has no changes to the picker, Combobox, Button or dependency lockfile since this base. I did not rerun tests locally or independently reproduce the author's repeated-run flake statistics; a passing run is not proof that every possible flake is gone.