Explain missing Pi provider models - #263
Conversation
Signed-off-by: Codex <codex@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6eafba1e8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const entries = (fresh?.models ?? []).filter( | ||
| (m) => !pi || !draft.provider || m.id.startsWith(`${draft.provider}/`), | ||
| ); | ||
| const piNoModelsMessage = |
There was a problem hiding this comment.
The exact reviewed commit has no Signed-off-by: trailer, so it violates the repository’s per-commit DCO requirement and will fail the DCO check even though the code patch is valid. Recreate this commit with git commit --signoff using the author’s verified effective name and email before adding it to PR history.
AGENTS.md reference: AGENTS.md:L153-L158
Useful? React with 👍 / 👎.
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No blocking findings; approvable from this review. Reviewed 6eafba1e8ed2935bb84efd2b00865cc6a2843210 against bebcd66e0adb27efa2c320f2bf72b8f3e63a8a45. This is a review comment, not an approval.
- The explanation is gated on a completed Pi catalog with no models for the selected provider, preserves other providers/custom IDs, and matches the native draft-environment discovery path. Optional copy improvement: name Advanced → Model → Refresh models explicitly, since reopening Browse reuses the catalog after an external auth.json change.
- Hosted CI is green: 3,791 Vitest tests, including all 10 picker tests, plus Rust/tool integration and Chromium/WebKit journeys. JavaScript checked synthetic merge
8fa6121fe2d598dd296590906862483af9d2b73aof this head and the stated base. Source-only review with independent credential-path review; no local code execution. Actual desktop Pi missing-credentials/recovery UI remains untested; Windows native was skipped. - The existing DCO comment does not match this exact head: its commit contains
Signed-off-by: Codex <codex@openai.com>, and the current DCO check passes. No DCO repair is indicated by that comment.
* origin/main: Explain missing Pi provider models (#263) Browse Goose models and enter provider API keys (#230) test(agents): check model lookup Cancel by visible text (#259) Ask before mentioning people outside the channel (#257) Refine direct message opening (#107) feat(messages): report messages to community moderators (#255) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>
* origin/main: ci: publish scheduled macOS test prereleases (#262) feat: add private text feedback plugin (#242) 🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#268) perf(sidebar): stop rerendering every row's menu on channel switch (#265) Explain missing Pi provider models (#263) Browse Goose models and enter provider API keys (#230) test(agents): check model lookup Cancel by visible text (#259) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/profiles/ProfileAgentIdentity.test.tsx
…-image * origin/main: (23 commits) fix(agents): recover status polling and scope failure diagnostics (#283) Share avatar editing across community profiles and managed agents (#271) feat(profiles): archive, unarchive and delete agents from the profile pane (#256) ci: run browser journeys on three shards per engine (#280) ci: publish scheduled macOS test prereleases (#262) feat: add private text feedback plugin (#242) 🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#268) perf(sidebar): stop rerendering every row's menu on channel switch (#265) Explain missing Pi provider models (#263) Browse Goose models and enter provider API keys (#230) test(agents): check model lookup Cancel by visible text (#259) Ask before mentioning people outside the channel (#257) Refine direct message opening (#107) feat(messages): report messages to community moderators (#255) perf(channels): stop rerendering message rows after each channel switch (#269) feat(profiles): open targeted agent editor from owner profile (#254) Let plugins declare local commands and HTTPS origins (#169) feat(profiles): show agent metadata and copyable nip05 (#253) Organize app and community settings (#173) Add status badge cutouts to avatars (#211) ...
Why
Pi can return no models for a selected provider when credentials are missing. The model menu then offers no clear next step.
What
Show a provider-neutral explanation in the Pi model menu and below the picker. Point users to Advanced → Environment overrides or Pi's auth.json, then ask them to refresh models.
How
Use the existing Pi model catalog and selected provider. This adds no provider-specific authentication checks.
Risk
Limited to the Pi model picker. The message gives setup guidance but cannot identify the exact reason Pi omitted a provider.
Testing
No manual desktop testing yet. The Pi model picker needs a UI check with a provider absent from the local Pi catalog.
Generated with Codex