Import an exact inventory identity from its selected source with retry - #288
Conversation
e88ada9 to
f39602d
Compare
c1d7711 to
d2b916e
Compare
f39602d to
60716f0
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Star Lord automated source review, posted via Wes’s account.
Reviewed head 60716f033eecd5cd82c48c087e2a758eb1a5aa95 against base/merge-base d2b916ea213bad986ac561d93dcd93a3ca2a8887.
One P2 finding: the new selected-identity dialog removes the destination-entry path when no community is selected (inline below). Preserve an explicit destination choice and obtain a fresh preview before enabling Import.
I inspected the complete 13-file delta and traced inventory selection, source retry/switching, preview/write fencing, repair-only fallback, and the existing native import boundary. The native path retains source/destination binding, duplicate-key checks at preparation and save, and configured/stopped persistence. Earlier stacked-base findings are not duplicated here.
Validation: source-only review of immutable, hash-verified extracts; no dirty working-tree inputs. No tests, builds, PR-code execution, app launches, credential access or CI checks. Browser/native behavior and human acceptance remain unverified. This is a non-blocking COMMENT, not approval or merge authorization.
60716f0 to
ff3df8f
Compare
d2b916e to
1dd0e01
Compare
ff3df8f to
bafa103
Compare
4a8e173 to
41b95c8
Compare
bafa103 to
dbb02bc
Compare
41b95c8 to
de596d4
Compare
dbb02bc to
f151b52
Compare
de596d4 to
69c3594
Compare
f151b52 to
fc4e551
Compare
69c3594 to
441274d
Compare
fc4e551 to
9d550e9
Compare
973f265 to
3814d98
Compare
9d550e9 to
cace21a
Compare
3814d98 to
baefabc
Compare
2f0505c to
b49e8b5
Compare
0209344 to
91e5f77
Compare
b49e8b5 to
299d9b1
Compare
299d9b1 to
d9d83f2
Compare
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No actionable code blockers found; ready for code approval. Reviewed head d9d83f2069bd397bfdd22c5852a1a01d6ba3d5d0 against base/merge-base 31a89276a48d254ff550aef3c8689b5a6dee51f0 (#287).
The previous destination-entry finding is addressed: Personal space now permits an explicit destination, edits invalidate the old preview, and the mounted card-to-dialog regression reaches import after a fresh preview. Rechecked exact-key/source selection, retry, destination-change cleanup, repair-only fallback, and the unchanged native duplicate-custody/source-binding checks. Imports remain configured and stopped. Independent bounded UI/lifecycle review found no additional blocker.
Validation: successful hosted CI tested merge f21f7a3eeaabda1f415add08e3bf4b9eea5c18b8 with exactly those head/base parents. JavaScript passed 433 files / 5,162 tests, including the repaired flow; native import-boundary tests, Rust/tool integration, Chromium/WebKit journeys, measurements, DCO and security checks passed. Windows validation was skipped. The older failed aggregate belongs to a superseded cancelled workflow. No broad suites rerun locally.
Merge caveats: this still targets the open #287 feature branch, not main; land/retarget in stack order and recheck the resulting base. Browser fixtures and CI do not establish real native credential/storage import or human acceptance; confirm that required acceptance before treating this as fully validated. I did not launch the app or touch credentials. Inspected the full feature diff, PR text and three attached screenshots.
This is a readiness COMMENT, not approval or merge authorization.
31a8927 to
0317113
Compare
Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
d9d83f2 to
6f8d4a9
Compare
* origin/main: Import an exact inventory identity from its selected source with retry (#288) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/bundled/agents/AgentsPage.tsx
* origin/main: feat(channels): archive and delete channels from settings (#385) feat(updates): add in-app auto-updates with restart toast (#312) fix(ui): keep background loading from shifting populated views (#418) Improve member and agent identity previews (#412) Fix initial emoji autocomplete selection (#419) Add community membership settings (#348) Keep nested replies compact and place actions above message text (#367) Import an exact inventory identity from its selected source with retry (#288) ci: add gated macOS preview updater feed promotion (#414) Set up incomplete inventory identities through a working Use here dialog (#287) Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz> # Conflicts: # src/app/App.tsx
* origin/main: (58 commits) flake fix: keep restored reading anchor out of bottom follow (WebKit scroll measurement) (#407) Replace fixed browser-test waits with conditions, gates and the clock (#373) feat(updates): show installed version in Software Updates settings (#430) fix(desktop): allow deep-link delivery to the main webview (#432) feat(shell): open your profile from the account menu avatar (#390) Polish top bar and animate contextual sidebar toggle (#360) fix(profiles): preserve nonlocal agent identity in profile fallback (#327) test(agents): pause the status poll around the failed-Stop checks (#431) fix(sidebar): paint channel rows with the scroller contents (#428) feat(channels): archive and delete channels from settings (#385) feat(updates): add in-app auto-updates with restart toast (#312) fix(ui): keep background loading from shifting populated views (#418) Improve member and agent identity previews (#412) Fix initial emoji autocomplete selection (#419) Add community membership settings (#348) Keep nested replies compact and place actions above message text (#367) Import an exact inventory identity from its selected source with retry (#288) ci: add gated macOS preview updater feed promotion (#414) Set up incomplete inventory identities through a working Use here dialog (#287) Show saved local and relay inventory while retaining existing import controls (#286) ...
* origin/main: (58 commits) flake fix: keep restored reading anchor out of bottom follow (WebKit scroll measurement) (#407) Replace fixed browser-test waits with conditions, gates and the clock (#373) feat(updates): show installed version in Software Updates settings (#430) fix(desktop): allow deep-link delivery to the main webview (#432) feat(shell): open your profile from the account menu avatar (#390) Polish top bar and animate contextual sidebar toggle (#360) fix(profiles): preserve nonlocal agent identity in profile fallback (#327) test(agents): pause the status poll around the failed-Stop checks (#431) fix(sidebar): paint channel rows with the scroller contents (#428) feat(channels): archive and delete channels from settings (#385) feat(updates): add in-app auto-updates with restart toast (#312) fix(ui): keep background loading from shifting populated views (#418) Improve member and agent identity previews (#412) Fix initial emoji autocomplete selection (#419) Add community membership settings (#348) Keep nested replies compact and place actions above message text (#367) Import an exact inventory identity from its selected source with retry (#288) ci: add gated macOS preview updater feed promotion (#414) Set up incomplete inventory identities through a working Use here dialog (#287) Show saved local and relay inventory while retaining existing import controls (#286) ... Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
🤖
Summary
Details
Screenshots
Captured from the browser test fixture at this PR's head.
Agents from another installation appear as cards with Import
Import review names the source and the destination community
With no selected community, import review asks for a destination community first