Show saved local and relay inventory while retaining existing import controls

[loganj]

🤖

Summary

• The Agents page now shows one inventory. It combines agents saved on this computer with agents found on the relay. Each identity appears once, matched by its exact public key.
• The existing import controls stay where they are for now. Later PRs in this stack add actions to the inventory cards.

Details

• At startup, the app records only the names, public keys, and source labels from old installations. It does not read keys, set up an agent, or start anything.
• Agents that are set up on this computer keep their Start, Stop, and Edit controls. Identities found elsewhere appear in a read-only section.
• If one source fails to load, the other source stays visible with a warning.
• Hosts without the saved inventory keep the older My agents and read-only library sections.
• The first part of this work, Browse legacy identities without a destination and review text before cloning #285, is merged; this PR targets main.

Screenshots

Captured from the browser test fixture at this PR's head.

One inventory lists local agents in this community, local agents in other communities, and agents available to import

The actions menu offers the same local controls for each setup of an agent

[wesbillman]

Star Lord automated source review — via Wes’s account

Reviewed head 6bf98c3d9a4049ef6f18d13c9f4b8b250bedbf11 against base/merge-base 3e1cc1b6d4f6e37f22f65e1677e1eee1cc3cf3e5.

One actionable finding, inline: the unified inventory makes existing local controls depend on the selected relay community, removing recovery Stop and editing for configured agents outside that scope. This conflicts with the stated control-retention goal.

Scope: complete 18-file diff; native metadata migration/persistence, exact-key inventory joining, supported local-control callers, relay-session lifecycle, older-host fallback, and regression-test source. Reviewed immutable GitHub source extracts (Git-blob verified), not a dirty checkout. No additional actionable findings in that scope.

Source-only review: no PR code, tests, builds, app launches, credential operations, or live workflows were executed. CI was not checked in this cycle; runtime/native/browser behavior and human acceptance remain unverified. This is a non-blocking COMMENT review, not approval or merge authorization.

[wesbillman]

Star Lord automated source review, published via Wes’s account

Reviewed head 75681781134d6dda20c1318064be978140d0aa26 against base bf1919fd7221b19bb9c2d3d48769bed70926cdc2.

No new actionable findings in this bounded follow-up. The earlier P2 about losing local controls outside the selected community is addressed in source: localSetups() retains every configured setup, and InventoryIdentityCard renders each setup’s exact-ID controls and menu entries regardless of the current destination. Discovery-only identities remain read-only.

Also checked the revised startup inventory reconciliation: missing/removed sources drop only their own provenance, another remaining source preserves the identity, malformed sources preserve prior inventory with a warning, and local configured agents remain separate from this metadata cleanup. Traced native startup/store writes and the affected inventory/control callers; reviewed the added component and Rust regression-test source. Unchanged areas covered by the earlier review were not reopened.

Validation limits: immutable, Git-blob-verified source extracts only; no dirty checkout inputs. No PR code, tests, builds, app launches, credentials, or live workflows were executed. CI was not assessed. Native/browser behavior, persistence under real failures, and human acceptance remain unverified. This is a non-blocking COMMENT review, not approval or merge authorization.

[wesbillman]

Automated source review — Star Lord

Published through Wes’s account. Follow-up to the earlier reviewed revision, focused on the actual integration changes and preservation of the prior fix.

No new actionable findings in the reviewed changes.

• The earlier local-controls issue remains addressed: every saved configured setup retains its exact-ID controls, including setups outside the selected community and while disconnected.
• Traced the startup metadata migration into the newer launch queue and defaults-aware snapshots. Parked metadata remains separate from executable agent records; the migration does not add queued starts or change saved launch preferences. Failed discovery preserves the previous source inventory and surfaces a warning.
• Checked the newer page/library integration, older-host fallback, import focus handoff, and dialog/action success, cancel, failure and retry paths at source level. Also inspected the PR description, both attached fixture screenshots, changed files and commit messages for public-material disclosures; no new actionable privacy finding.

Reviewed head: f99a81a4ae15a8f14ff567e916b36577b5464763
Reviewed base: 3237b095109dc7c406abab2c688c266b147297d6

Limits: Source-only review of immutable commit contents; git diff --check passed. No PR code, tests, builds, app or native migration was executed, and CI was not assessed in this pass. Keyboard/focus behavior and native startup/recovery remain unverified at runtime. This COMMENT is not approval or merge authorization.