Skip to content

Fix initial emoji autocomplete selection - #419

Merged
wesbillman merged 1 commit into
mainfrom
kennylopez-emoji-autocomplete
Sep 29, 2026
Merged

Fix initial emoji autocomplete selection#419
wesbillman merged 1 commit into
mainfrom
kennylopez-emoji-autocomplete

Conversation

@klopez4212

@klopez4212 klopez4212 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Typing :joy could retain an early community-emoji match and scroll past the best result when Unicode results arrived. Keep automatic selection on the first ranked result while preserving explicit keyboard and pointer choices.

Validation: focused Chromium/WebKit regressions, typechecking, and formatting passed. Full just scan is running; native-app verification remains deferred.

@klopez4212
Fix initial emoji autocomplete selection
d471b50 
Signed-off-by: klopez4212 <klopez4212@gmail.com>
@klopez4212
klopez4212 marked this pull request as ready for review September 29, 2026 17:59
@klopez4212
klopez4212 requested review from a team, comp615 and wesbillman as code owners September 29, 2026 17:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T18:06:56.540258Z d471b50 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

wesbillman
wesbillman reviewed Sep 29, 2026
View reviewed changes

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source review (via Wes’s account)

Reviewed head d471b50b3916747ffeb331756269cd46944c859b against base 32982724223d8090441415ed89ddf7cb7a8d286e.

No concrete production correctness or security defect found. The implementation meets the 9/10 minimalness/elegance/correctness bar on source inspection: leaving implicit selection unpinned lets the first ranked Unicode result replace an early community match, while keyboard/pointer-selected IDs survive reordering. I also traced disappearing selections, retry/error recovery, query invalidation, editor focus and rejected acceptance; the existing ownership and no-fallthrough-to-send protections remain intact.

Required review-evidence follow-up (not a production-code blocker)

Please complete the browser-test evidence in the PR description as required by AGENTS.md:105–123 and docs/contributing.md:431–448. It currently reports only “focused Chromium/WebKit regressions” passing, without the required case inventory, browser-only rationale or fail-then-pass evidence. Record:

  • One new browser case, one existing case extended, zero removed; no replacement coverage was removed.
  • The real popup scrolling/keyboard insertion and emoji-provider/composer wiring contract that justifies the browser case; the controlled publication test covers implicit versus explicit selection.
  • The command, snapshots, engines and observed failure with the new regression assertions against the old selection behavior, followed by the passing fixed result. If the pre-fix run has not been performed, explicitly leave it deferred rather than treating green CI as fail-then-pass evidence.

No extra production abstraction or broad test rewrite is requested.

Evidence and limitations

  • Inspected all three changed files and their relevant callers/contracts. Public-surface inspection covered the PR description (no attached images), changed source/fixture/test material and the single commit’s metadata; no disclosure finding in those surfaces. Also visually inspected both hosted emoji-first-result.png captures: :joy: is highlighted at the top of the synthetic popup.
  • One hosted CI snapshot: run 36608200113 succeeded, including all 12 journey shards, JavaScript, Rust/tool integration, browser measurements and required checks. Windows native validation was skipped.
  • Downloaded reports independently confirm all 22 cases in typeahead.spec.mjs passed in each of Chromium and WebKit, with no retries, including both changed scenarios and retry/focus recovery. These ran on CI merge a01379437dd4e8fff93714104e054e8cb76e5527; its tree includes 56 incoming-base file changes and is not identical to the feature head. The completion host, emoji provider/search, typeahead.spec.mjs and emoji fixture are unchanged between that merge and the reviewed head. The full-file passes therefore establish hosted merged-state coverage, not a standalone feature-head run. This is hosted evidence, not a local test run or pre-fix failure demonstration.
  • Source-only review: no PR code, tests or application executed locally. Native-app, assistive-technology and human acceptance remain unverified. This COMMENT is not approval, merge authorization or a completed readiness checklist.

@wesbillman
wesbillman merged commit d149d81 into main Sep 29, 2026
20 checks passed
@wesbillman
wesbillman deleted the kennylopez-emoji-autocomplete branch September 29, 2026 20:08
johnmatthewtennant pushed a commit that referenced this pull request Sep 29, 2026
Sol
Merge remote-tracking branch 'origin/main' into sol/agent-update-drafts
19ea00a 
* origin/main:
  feat(channels): archive and delete channels from settings (#385)
  feat(updates): add in-app auto-updates with restart toast (#312)
  fix(ui): keep background loading from shifting populated views (#418)
  Improve member and agent identity previews (#412)
  Fix initial emoji autocomplete selection (#419)
  Add community membership settings (#348)
  Keep nested replies compact and place actions above message text (#367)
  Import an exact inventory identity from its selected source with retry (#288)
  ci: add gated macOS preview updater feed promotion (#414)
  Set up incomplete inventory identities through a working Use here dialog (#287)

Signed-off-by: Sol <49aa1f65411fd096d2e2ec144f1e7aa36fdc76d1b907cfdf7be000c66f9d3b8e@buzz.block.builderlab.xyz>

# Conflicts:
#	src/app/App.tsx
TheSentinel454 pushed a commit that referenced this pull request Sep 29, 2026
Elrond
Merge main into elrond/community-delete-app-draft
b7bddc1 
* origin/main: (58 commits)
  flake fix: keep restored reading anchor out of bottom follow (WebKit scroll measurement) (#407)
  Replace fixed browser-test waits with conditions, gates and the clock (#373)
  feat(updates): show installed version in Software Updates settings (#430)
  fix(desktop): allow deep-link delivery to the main webview (#432)
  feat(shell): open your profile from the account menu avatar (#390)
  Polish top bar and animate contextual sidebar toggle (#360)
  fix(profiles): preserve nonlocal agent identity in profile fallback (#327)
  test(agents): pause the status poll around the failed-Stop checks (#431)
  fix(sidebar): paint channel rows with the scroller contents (#428)
  feat(channels): archive and delete channels from settings (#385)
  feat(updates): add in-app auto-updates with restart toast (#312)
  fix(ui): keep background loading from shifting populated views (#418)
  Improve member and agent identity previews (#412)
  Fix initial emoji autocomplete selection (#419)
  Add community membership settings (#348)
  Keep nested replies compact and place actions above message text (#367)
  Import an exact inventory identity from its selected source with retry (#288)
  ci: add gated macOS preview updater feed promotion (#414)
  Set up incomplete inventory identities through a working Use here dialog (#287)
  Show saved local and relay inventory while retaining existing import controls (#286)
  ...
TheSentinel454 pushed a commit that referenced this pull request Sep 29, 2026
Elrond
Merge main into elrond/community-delete-app-draft
b6c37cf 
* origin/main: (58 commits)
  flake fix: keep restored reading anchor out of bottom follow (WebKit scroll measurement) (#407)
  Replace fixed browser-test waits with conditions, gates and the clock (#373)
  feat(updates): show installed version in Software Updates settings (#430)
  fix(desktop): allow deep-link delivery to the main webview (#432)
  feat(shell): open your profile from the account menu avatar (#390)
  Polish top bar and animate contextual sidebar toggle (#360)
  fix(profiles): preserve nonlocal agent identity in profile fallback (#327)
  test(agents): pause the status poll around the failed-Stop checks (#431)
  fix(sidebar): paint channel rows with the scroller contents (#428)
  feat(channels): archive and delete channels from settings (#385)
  feat(updates): add in-app auto-updates with restart toast (#312)
  fix(ui): keep background loading from shifting populated views (#418)
  Improve member and agent identity previews (#412)
  Fix initial emoji autocomplete selection (#419)
  Add community membership settings (#348)
  Keep nested replies compact and place actions above message text (#367)
  Import an exact inventory identity from its selected source with retry (#288)
  ci: add gated macOS preview updater feed promotion (#414)
  Set up incomplete inventory identities through a working Use here dialog (#287)
  Show saved local and relay inventory while retaining existing import controls (#286)
  ...

Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesbillman wesbillman wesbillman approved these changes
@comp615 comp615 Awaiting requested review from comp615 comp615 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klopez4212 @wesbillman