Enrich visible identities and fence profile and selected-source completion

[loganj]

🤖

Summary

• Profile names and pictures now load for identities that are discovered or available to import. Artwork saved on this computer still wins.
• Late results cannot overwrite newer choices. A late import preview cannot replace the source you chose. Late profiles are ignored after you switch accounts.
• If profiles fail, discovery stays visible, and Refresh agents retries.

Details

• This PR changes only the inventory view and its tests.
• Based on Discover saved identities across joined communities with names, pictures and retry #291.

Screenshots

Captured from the browser test fixture at this PR's head.

Discovered agents show their profile names and pictures

[wesbillman]

Star Lord automated source review, published via Wes’s account.

No new actionable findings in this PR’s incremental change. Reviewed the 22-line production addition and the added mounted-test sources against the existing inventory, naming/artwork, profile-directory and import-control lifecycles. Background enrichment reuses the shared missing-profile/coalescing path and session retirement fences; discovery and native actions remain independent of enrichment failures. The source-selection tests exercise the existing preview-generation fence and serialized native operation lane.

• Head: 127f03a5c946209856c7e5021627d4cb40761968
• Base / merge base: d57b648a7f8b00a6fada8e1d769762a0dcaf751f (stacked on #291)
• Inputs: immutable, hash-verified source extracts; no dirty checkout inputs.

This is an incremental review, not clearance of findings on the stacked base. Source-only: no PR code, tests, builds, app or native workflows were executed; no CI status was assessed. Browser/native behavior and human acceptance remain unverified. This COMMENT is not an approval or merge authorization.

[wesbillman]

Star Lord automated source review, published via Wes’s account.

No new actionable findings in this bounded follow-up. Compared the current revision with the previously reviewed head 127f03a5c946209856c7e5021627d4cb40761968. The production addition in UnifiedInventory.tsx is unchanged; the branch also includes substantive base updates and additional test coverage, not merely a new SHA.

Rechecked the incremental enrichment against the current base: shared missing-profile reads coalesce, failed reads remain retryable, and session disposal/abort fences reject retired results. The effect tracks the profile-directory instance as well as connection generation, including cached-to-live session replacement. Existing saved-artwork precedence, exact-key naming, discovery/action independence, and import preview-generation/source-token binding remain intact in the inspected paths. Read the added mounted-test sources; they were not executed.

• Head: 82c54783ba20116df5b901b0c0ddac6720b9d606
• Base: ef9d488719c60a1e3885eadfbcb340b49c1d4155 (stacked on #291)
• Inputs: immutable, Git-blob/hash-verified source extracts; no dirty checkout inputs.

This is an incremental follow-up, not blanket clearance of the stacked base. Source-only: no PR code, tests, builds, app launches, or native workflows were executed; CI status was not assessed. Browser/native behavior and human acceptance remain unverified. This COMMENT is not an approval or merge authorization.

[wesbillman]

Star Lord automated source review

Published via Wes’s account; non-blocking COMMENT review.

No new actionable findings in this bounded integration follow-up.

• Head: 294f68fb3dae8a1c7b09935d028415bcd6d0d41e
• Base: 7912bea6456a76ad442cb010dc6751d3832d7bc5
• Previous covered head: 82c54783ba20116df5b901b0c0ddac6720b9d606

The added/removed lines in this PR’s three-file feature patch are unchanged from the previous review, while the actual file contents include inherited base updates. I checked their integration rather than reopening the unchanged feature.

• UnifiedInventory.tsx:84–105 retains the existing background profile-enrichment effect and session/profile-directory dependencies. The inherited localSetups name selection at lines 122–127 matches the configured setup represented by the card and does not gate profile loading or local actions.
• Rechecked profile request coalescing, failed-read retry eligibility, and disposal/abort fences in profile-directory.ts, plus the unchanged import-preview generation fence. Saved-artwork precedence and separation of display enrichment from local custody/actions remain intact in the inspected paths.
• Read the inherited exact-setup Duplicate/Delete assertions, disconnected/switching local-control regression, and destination-entry/source-selection tests. The unchanged selected-source tests still bind the import to the selected preview token. The sole PR commit has a DCO sign-off trailer.

Validation limits: source-only inspection using 40 Git-blob-verified extracts; no dirty checkout inputs. Tests were read, not run. No builds, CI assessment, PR-code execution, app launches, or native workflows. This follow-up does not clear unrelated findings or validate the inherited native admission implementation in earlier stack layers. Runtime behavior and human acceptance remain unverified; this is not an approval or merge authorization.