Skip to content

Group inventory by community and use compact rows outside the current community - #290

Merged
loganj merged 1 commit into
mainfrom
feat/inventory-community-rows
Sep 30, 2026
Merged

loganj merged 1 commit into
mainfrom
feat/inventory-community-rows

Conversation

@loganj

@loganj loganj commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🤖

Summary

  • The inventory now groups identities by the communities they are known to belong to.
  • Cards in the current community stay full size. Cards for other communities use compact rows, so the page is easier to scan.

Details

  • A group shows a known association. It does not prove exclusive membership or channel admission.
  • Setups in the current community show Start, Stop, and Edit. Local agents in other communities offer Clone to create a new identity here.
  • Archived identities stay hidden unless a local control must stay reachable.

Screenshots

Captured from the browser test fixture at this PR's head (9ff2ef8).

My agents grouped by community

My agents grouped by community

Community groups at a narrow width

Community groups at a narrow width

@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from 9d68391 to c6f5bd0 Compare September 25, 2026 19:38
@loganj
loganj force-pushed the feat/inventory-community-rows branch 2 times, most recently from 495ddef to 883e818 Compare September 26, 2026 15:06
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from c6f5bd0 to eb42230 Compare September 26, 2026 15:06
@loganj
loganj marked this pull request as ready for review September 26, 2026 15:11
@loganj
loganj requested review from a team, comp615 and wesbillman as code owners September 26, 2026 15:11

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source review

Reviewed through Wes’s account; this is a non-blocking COMMENT, not an approval or merge recommendation.

  • Head: 883e8184b331a7071d24e84ff3fc693de63a5e76
  • Base: eb42230008cab55918d50ad47138449b0b3a9c17
  • Result: No new actionable correctness defects identified in this eight-file change relative to its stacked base.

Reviewed the community partitioning and deterministic identity placement, current-community tile versus compact-row rendering, heading/disclosure semantics, source-selection retention, action wiring, shared-card callers, and changed test assertions. Existing findings on earlier stack layers are not cleared by this result.

Validation limits: Source inspection only, using immutable head/base files verified against Git blob hashes; no working-tree modifications, PR code execution, tests, builds, or app launches. Responsive row/disclosure geometry, actual browser/assistive-technology behavior, and native Import/Clone/Start/Stop workflows remain unverified. CI was not checked in this cycle.

@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from eb42230 to 3f08842 Compare September 26, 2026 15:45
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 883e818 to 3c77606 Compare September 26, 2026 15:45

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source re-review

Reviewed through Wes’s account; this is a non-blocking COMMENT, not approval or merge authorization.

  • Head: 3c7760618bd033d6dacc75a0dc365557a7128dc3
  • Base: 3f08842f761be68f6acc2d4937f0fabe42d4a4e5 (#289)
  • Result: No new actionable defects identified in this revision.

Compared the current tree with the previously reviewed head 883e8184b331a7071d24e84ff3fc693de63a5e76: actual content changes are limited to the inherited agent-status wording, browser-test selectors/assertions, and fixture forwarding of inventory requests. Traced those changes against their callers and fixture data. The eight-file community-grouping/compact-row delta is unchanged in content; its current head/base diff was also inspected. This result does not clear findings already reported on earlier stack layers.

Validation limits: Source inspection only, using immutable Git-blob-verified extracts; no dirty checkout inputs. No PR code, tests, builds, app workflows or credential operations were executed, and CI was not checked. Responsive layout, browser/assistive-technology behavior, native workflows and human acceptance remain unverified.

@loganj
loganj force-pushed the feat/inventory-community-rows branch from 3c77606 to f20f3da Compare September 28, 2026 15:12
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from 3f08842 to feaf0fb Compare September 28, 2026 15:12

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source re-review

Reviewed via Wes’s account. This is a non-blocking COMMENT, not an approval or merge authorization.

  • Head: f20f3dabc132b2cc8d18b25b0c2587b5618fd4c0
  • Base: feaf0fbce93af0296fed367faece22f0d7f9fc20 (#289)
  • Result: No new actionable defects identified in this bounded follow-up.

Compared the current eight-file PR delta with the previously reviewed head 3c7760618bd033d6dacc75a0dc365557a7128dc3. Six touched files have identical content; the changes in AgentCard.tsx and its test are the inherited npub presentation and regression assertion, already present in the current base. Inspected that integration with the shared card callers, compatibility-library key validation, and the inventory’s existing exact-key disclosure/action wiring. The community-grouping/compact-row implementation remains unchanged in content. This does not clear findings on earlier stack layers or constitute a fresh review of unrelated base changes.

Validation limits: Source inspection only, using immutable Git-blob-verified extracts; no dirty checkout inputs. No PR code, tests, builds, app workflows or credential operations were executed; CI was not checked. Responsive row/disclosure layout, browser/assistive-technology behavior, native Import/Clone/Start/Stop workflows and human acceptance remain unverified.

@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from feaf0fb to 501b879 Compare September 28, 2026 16:43
@loganj
loganj force-pushed the feat/inventory-community-rows branch from f20f3da to 3dc6dd0 Compare September 28, 2026 16:43

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star Lord automated source re-review

Reviewed via Wes’s account. This is a non-blocking COMMENT, not approval or merge authorization.

  • Head: 3dc6dd0d8e625412b2832893e126e08fb9afef40
  • Base: 501b8793b433d56e06674c173e2a23faeb9deaf2 (#289)
  • Result: No new actionable defects identified in this bounded follow-up.

Compared the eight touched files with previously reviewed head f20f3dabc132b2cc8d18b25b0c2587b5618fd4c0: five are byte-identical. The remaining changes integrate the base’s per-saved-setup controls and update their assertions. The PR-specific adjustment hides only the setup’s community label already supplied by its section heading, retaining labels for the other setups on the same identity row.

Traced canonical community grouping, original setup-object identity through localSetups, exact-native-ID Start/Stop and settings callbacks, and the revised multi-setup assertions. The inherited lifecycle controls remain reachable outside the selected community. This does not clear findings on earlier stack layers or reopen unrelated base changes.

Validation limits: Source inspection only, using Git-blob-verified immutable extracts; no dirty checkout inputs. No PR code, tests, builds, app workflows or credential operations were executed; CI was not checked. Responsive layout, browser/assistive-technology behavior, native controls and human acceptance remain unverified.

@loganj
loganj marked this pull request as draft September 28, 2026 19:04
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 3dc6dd0 to d868e36 Compare September 28, 2026 19:57
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch 2 times, most recently from 1a19b55 to cfe416c Compare September 28, 2026 20:11
@loganj
loganj force-pushed the feat/inventory-community-rows branch 2 times, most recently from 5c56b8c to a78c7ff Compare September 28, 2026 20:36
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from cfe416c to 03b1ed6 Compare September 28, 2026 20:36
@loganj
loganj force-pushed the feat/inventory-community-rows branch from a78c7ff to aac41f3 Compare September 28, 2026 21:28
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch 2 times, most recently from 1bcee53 to f3b92c6 Compare September 28, 2026 21:48
@loganj
loganj force-pushed the feat/inventory-community-rows branch from aac41f3 to 1216cc1 Compare September 28, 2026 21:48
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from f3b92c6 to e51e200 Compare September 29, 2026 14:59
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 1216cc1 to 95926ef Compare September 29, 2026 14:59
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from e51e200 to dd9d1e8 Compare September 29, 2026 15:29
@loganj
loganj force-pushed the feat/inventory-community-rows branch 2 times, most recently from ebcea16 to 4a82875 Compare September 29, 2026 17:13
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch from dd9d1e8 to ec654eb Compare September 29, 2026 17:13
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 4a82875 to 2821d14 Compare September 29, 2026 18:59
@loganj
loganj force-pushed the feat/inventory-active-dialogs branch 2 times, most recently from 02088a4 to 44b872d Compare September 30, 2026 14:44
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 2821d14 to 6f9f979 Compare September 30, 2026 15:09
Base automatically changed from feat/inventory-active-dialogs to main September 30, 2026 16:03
… community

Signed-off-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
@loganj
loganj force-pushed the feat/inventory-community-rows branch from 6f9f979 to 9ff2ef8 Compare September 30, 2026 16:08
@loganj
loganj marked this pull request as ready for review September 30, 2026 16:51

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new actionable findings in this bounded follow-up: community grouping, exact-setup controls, and the inherited card/status integration remain consistent; earlier stack findings are not cleared.

Star Lord’s automated source review via Wes’s account; COMMENT only, not approval. Head 9ff2ef8de85b416b40f9c0953a16684db84ab181; base 9ab4a1792b0d2cc60c9734baf1dc45911ee8bc83.

Inspected the changed source, callers, error/retry focus paths, public description and both fixture screenshots. Hosted checks passed in one snapshot (Windows skipped); no local tests, app execution or native workflows were run, so runtime focus, responsive behavior and human acceptance remain unverified.

@loganj
loganj merged commit 61d0bd5 into main Sep 30, 2026
33 of 37 checks passed
@loganj
loganj deleted the feat/inventory-community-rows branch September 30, 2026 20:13
cynfria pushed a commit that referenced this pull request Sep 30, 2026
…followup

* origin/main:
  Group inventory by community and use compact rows outside the current community (#290)
  chore: enable Cmd+R reload in production builds (#468)
  ci: run playwright jobs in the pinned docker image (#469)
  fix(profile): let the web profiling page follow the browser window size (#467)
  Let plugin pages publish NIP-AR artifacts and embed the host thread view (#434)

Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants