fix(profile): let the web profiling page follow the browser window size - #467
Merged
Merged
Conversation
The profiler opened its page with Playwright's default emulated 1280x720 viewport, so the app stayed that size no matter how the Chrome window was resized. Disable viewport emulation so the page tracks the window. Co-authored-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz> Signed-off-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz>
kalvinnchau
requested review from
a team,
comp615 and
wesbillman
as code owners
September 30, 2026 18:53
wesbillman
approved these changes
Sep 30, 2026
cynfria
pushed a commit
that referenced
this pull request
Sep 30, 2026
…followup * origin/main: Group inventory by community and use compact rows outside the current community (#290) chore: enable Cmd+R reload in production builds (#468) ci: run playwright jobs in the pinned docker image (#469) fix(profile): let the web profiling page follow the browser window size (#467) Let plugin pages publish NIP-AR artifacts and embed the host thread view (#434) Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bin/just web profileopens Chrome, but the app stays at a fixed size inside the window and ignores window resizing.scripts/profile-dev.mjscreated its page withbrowser.newPage(), which applies Playwright's default emulated 1280x720 viewport. The window resizes; the page inside it does not.Change
Open the profiling page with
viewport: nullso it tracks the real window size.Evidence
Headed Chrome, window resized over CDP (
Browser.setWindowBounds), readinginnerWidthxinnerHeight:{ viewport: null }bin/just web profile --network --tracerun by Kalvin against a live relay with this change: the app follows the window.node --test tests/integration/profile-dev.test.mjs: 35 pass, 0 fail.biome check scripts/profile-dev.mjs: clean.Not covered
No regression test added. The profile-dev suite drives a fake browser, so a test could only assert that the option is passed, not that the page resizes.