chore: enable Cmd+R reload in production builds - #468
Merged
Merged
Conversation
The reload host shortcut was gated behind import.meta.env.DEV, so built apps had no Cmd+R refresh. Register it unconditionally as "Reload Buzz" (id app-reload), matching the always-on reload shortcut in the legacy buzz desktop app. Signed-off-by: Kalvin Chau <kalvin@block.xyz>
kalvinnchau
marked this pull request as ready for review
September 30, 2026 19:17
kalvinnchau
requested review from
a team,
comp615 and
wesbillman
as code owners
September 30, 2026 19:17
wesbillman
approved these changes
Sep 30, 2026
cynfria
pushed a commit
that referenced
this pull request
Sep 30, 2026
…followup * origin/main: Group inventory by community and use compact rows outside the current community (#290) chore: enable Cmd+R reload in production builds (#468) ci: run playwright jobs in the pinned docker image (#469) fix(profile): let the web profiling page follow the browser window size (#467) Let plugin pages publish NIP-AR artifacts and embed the host thread view (#434) Signed-off-by: Tree Trunks <6ba22921d9dc2ad0aa6ecdf63787ddd24726e266d866da31af69f2e4e146ace5@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Un-gates the Cmd+R reload host shortcut so built (production) apps support webview refresh. Previously the registration was wrapped in
if (import.meta.env.DEV), so Cmd+R did nothing in release builds.Why
The legacy buzz desktop app always registered Cmd+R (
useReloadShortcut-> WebSocket teardown ->window.location.reload()). buzz-app's port was dev-only, losing that parity in built apps. buzz-app's relay sockets are plain webviewWebSockets (src/features/relay/live.ts:207) torn down automatically by page reload, so the old native teardown shim is not needed; plainwindow.location.reload()is sufficient.Changes
src/app/shortcuts.ts: register the shortcut unconditionally; renamedevelopment-reload->app-reload(title "Reload Buzz"),HOST_SHORTCUT_ORDER.development->.reload(same order value).src/app/ShortcutSettings.test.tsx: assert the row unconditionally instead of branching onimport.meta.env.DEV.Validation
vitest run src/app/ShortcutSettings.test.tsx(14 passed),biome checkon touched files,tsc --noEmitclean.