fix: Compress simulate-keyboard and execute-dynamic-code skill prose#1976
Conversation
Both skills carried run-on paragraphs that restated facts documented elsewhere in the same file. Compress them without dropping any contract fact: - simulate-keyboard: drop ReleaseAll restatements (command spelling and ReleasedKeys are already in the Actions table and Output), tighten the PressEdgeObserved bullet, and convert the three press-edge diagnostics from one run-on bullet into a value/meaning/next-action table - execute-dynamic-code: tighten the pause-point hand-off paragraph and the live-state-injection paragraph, removing example enumerations and justification prose while keeping the reflection-permission and main-thread rules
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocumentation updates refine dynamic-code access constraints, pause-point workflows, PlayMode state injection, keyboard recovery semantics, and press-edge diagnostic guidance across mirrored skill specifications. ChangesSkill documentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Packages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md`:
- Around line 96-103: Update the press-edge recovery guidance so it is
action-specific: in
Packages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md lines
96-103, retain direct retry for Press but require KeyUp followed by KeyDown for
KeyDown recovery. Regenerate .agents/skills/uloop-simulate-keyboard/SKILL.md
lines 96-103 and .claude/skills/uloop-simulate-keyboard/SKILL.md lines 96-103
with the same guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d351ad39-1b95-48f2-bfc2-a65d8f05d585
📒 Files selected for processing (6)
.agents/skills/uloop-execute-dynamic-code/SKILL.md.agents/skills/uloop-simulate-keyboard/SKILL.md.claude/skills/uloop-execute-dynamic-code/SKILL.md.claude/skills/uloop-simulate-keyboard/SKILL.mdPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.md
CodeRabbit review: the diagnostics table said "Retry the input" for an edge consumed by a non-Dynamic update, but a missed KeyDown leaves the key held on the device, and KeyDown rejects an already-held key. Spell out the per-action recovery: Press retries directly, KeyDown needs KeyUp first.
Summary
Fact-preserving compression of two skills, following the same editorial rule as #1975 (state each fact once, drop restatements and justification prose).
ReleaseAllparagraph repeated the command spelling andReleasedKeys(both already in the Actions table / Output list). The three press-edge diagnostics were one run-on bullet; they are now a value → meaning → next-action table, which is also easier for an agent to apply mid-retry.Test plan
dist/darwin-arm64/uloop skills install --claude --agents; sources and generated.claude//.agents/copies verified byte-identical