fix: bind Signal Selection one-to-one to static DataSet members - #184
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field evidence
Real Siemens CID validation on ARSAS
147c664...improved from0/58to5/58represented static members, proving offline recovery runs but resolved members still lose their protocol identity. The same diagnostic also exposed a startupSingleOrDefault()exception in the first-run launcher.Root cause
ARIEC mandatory inventory was descriptor-centric: 58 static FCDA/FCD members produced 68 semantic descriptors. ARIEC PR #78 now makes the inventory member-centric and preserves exactly one descriptor per
(DataSetReference, MemberIndex), keeping the static member identity separate from any resolved runtime primary leaf.ARSAS changes
761fa0df9ca84fbe15352d2670f03fddbe8784baSingleOrDefault()launcher discovery executesExpected Siemens CID result
Sequence contains more than one elementdiagnosticPhysical CID validation remains required after merge.