Conversation
Owner
Author
Exact-good-base candidate builtThis PR is now validated with the same R7 workflow recipe that produced the previously accepted artifact. Proven base:
New candidate:
Diff from the exact good ARSAS base is still only:
No engine-lock change and no discovery/report/runtime source change. Physical test order: prove runtime parity first. Do not evaluate Save SCL until discovery/reporting is back at the accepted 58/58 + 58 report-backed baseline. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proven base — do not move
This PR is based directly on the physically accepted ARSAS finishing commit:
0d0b9204d6637e3d62e2eee94000386ae43cd0e9The engine lock remains exactly:
648124097621046f5f127ceb1cf853fea54db730(PR #135)This is the same ARSAS/engine pair used by SCL Interoperability R7 Build #176, artifact
10599133416.Scope
Correct one known SCL semantic mismatch after canonical serialization and before canonical reload validation:
MPLS_GGIO1.CBClsCounterSaved SCL target:
INSstVal bType = INT32The live discovery/runtime model is not changed.
Runtime freeze
Diff from
0d0b9204...is exactly:MainWindow.xaml.cs: one Save-SCL hook (+12 lines)Services/SclExportSemanticParityPatch.cs: output-only XML patchtests/ARSAS.Tests/SclExportSemanticParityPatchTests.cs: regressionsNo changes to:
engines/ARIEC61850.lock.jsonSafety
The patch is applied only when the live model contains the exact physical-reference object
.../MPLS_GGIO1.CBClsCounter.If the generated SCL cannot resolve that exact LN/DO/DOType/stVal shape, Save SCL fails closed instead of silently producing a guessed SCL.
If a future exporter shares the DOType with another object, the patch clones the DOType and repoints only CBClsCounter.
A non-integer saved instance
Valis removed rather than converted/guessed.Canonical reload validation runs after the patch.
Acceptance
First physical gate is unchanged runtime:
Only after runtime passes: