Conversation
masarray
marked this pull request as ready for review
September 3, 2026 06:32
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked physical-field fix on top of FAT v2 P5.3 / PR #236. This PR intentionally changes only the structured InformationReport projection seam needed for controlled relay retest.
Exact head before this patch:
937f57f46753968d4a6dbe0699848a841cde1f8a.Exact production commit:
4dd3880f1767a0af305aa80ed7bfa6d570c43486.Physical failure being closed
The relay proved static DataSet/RCB acquisition is healthy, but whole structured analog members such as
I_MHAI1.ThdA/V_MHAI1.ThdPPVreached the ARSAS report receive seam asREPORT_RAW_STRUCT. The old receive path always called the baselineMmsReportValueProjector, so model-backed scalar descendants never reached the existing live point cache.P5.4 wiring
888545bbca1e26040b3f7a86193e2dae013e964ffrom draft engine PR Add bounded two-cycle Sampled Values snapshot proof #106;LiveDiscoveryModelor opened SCL design model) to a small semantic report projection bridge;NativeIec61850Clientinstance and resets it on reconnect/replanning, so no model state crosses IEDs;REPORT_SEMANTIC_FALLBACKrather than inventing evidence or dropping the MMS association;Regression
SemanticReportProductionWiringRegressionTestslocks both boundaries:ReceiveReportMonitorSliceAsyncpath must call the model-backed semantic bridge, and hybrid planning must supply/reset its authority;ThdAstatic member remains semantically ambiguous at membership level (PrimaryValue == null) but a valid InformationReport fans out tophsA/phsB/phsC.cVal.mag.fwithsemantic-structured-leafprojection status and noREPORT_RAW_STRUCTparent update.Exact-head evidence
Engine:
888545bbca1e26040b3f7a86193e2dae013e964f.NET CI#432 / run33489485962: SUCCESSARSAS SHA
4dd3880f1767a0af305aa80ed7bfa6d570c43486:33495383195: SUCCESS, 169/169 focused tests33495383165: SUCCESS33495383203: SUCCESS33495383266: SUCCESSLocked exclusions
Software gates are GO for controlled physical retest. Physical GO is not claimed until the same relay/CID confirms the previously raw structured members reach the live FAT rows as valid scalar descendants without identity drift.