ability to disable grpc and/or event consumer for event history service by maki5 · Pull Request #3279 · opencloud-eu/opencloud

maki5 · 2026-08-10T13:32:36Z

for event history service now it's possible to enable/disable from config

grpc server
events consumer

codacy-production · 2026-08-10T13:35:48Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 18 complexity · 7 duplication

Metric Results

Complexity 18

Duplication 7

View in Codacy

🟢 Coverage 1.60% diff coverage · -0.02% coverage variation

Metric Results

Coverage variation ✅ -0.02% coverage variation (-1.00%)

Diff coverage ✅ 1.60% diff coverage

View coverage diff in Codacy

Coverage variation details

Coverable lines Covered lines Coverage

Common ancestor commit (1fa8950) 84104 19334 22.99%

Head commit (1d55c4d) 84151 (+47) 19326 (-8) 22.97% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

Coverable lines Covered lines Diff coverage

Pull request (#3279) 125 2 1.60%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

butonic · 2026-08-12T14:50:55Z

+				if err != nil {
+					return err
+				}
+			} else {


This only sets up the nats consumer. Unfortunately, the actual events.ConsumeAll(...) call still lives in the NewEventHistoryService. You will have te extract that into a separate module, like in https://github.com/opencloud-eu/opencloud/pull/3241/changes#diff-654db365a382a61398b04610d91188cc8b6d777398bd1b7a25793977e33231e0 ... although I still need to fix the failing tests it shows the different services that are started by the server command.

butonic · 2026-08-12T14:51:30Z

+		ch, err := events.ConsumeAll(consumer, "evhistory")
+		if err != nil {
+			return nil, err
+		}

-	eh := &EventHistoryService{ch: ch, store: store, cfg: cfg, log: log}
-	go eh.StoreEvents()
+		eh.ch = ch
+		go eh.StoreEvents()


This consumer will never be started if grpc has been disabled

…zation

…enthistory_event_handler_on_demand

@AlexAndBear

##### [\`7.5.0\`](https://github.com/opencloud-eu/opencloud/blob/HEAD/CHANGELOG.md#750---2026-08-25) ##### ❤️ Thanks to all contributors! ❤️ [@AlexAndBear](https://github.com/AlexAndBear), [@JammingBen](https://github.com/JammingBen), [@Svanvith](https://github.com/Svanvith), [@aduffeck](https://github.com/aduffeck), [@butonic](https://github.com/butonic), [@fschade](https://github.com/fschade), [@junkerderprovinz](https://github.com/junkerderprovinz), [@kulmann](https://github.com/kulmann), [@maki5](https://github.com/maki5), [@pbleser-oc](https://github.com/pbleser-oc), [@rhafer](https://github.com/rhafer), [@saw-jan](https://github.com/saw-jan), [@schweigisito](https://github.com/schweigisito), [@v-scharf](https://github.com/v-scharf) ##### ✅ Tests - test(api): update php test dependencies \[[#3335](opencloud-eu/opencloud#3335)] - fix(acceptance): fix running acceptance tests against host on Linux \[[#3358](opencloud-eu/opencloud#3358)] - fix(graph): adding the same user as multiple members in a group ([#3354](opencloud-eu/opencloud#3354)) \[[#3356](opencloud-eu/opencloud#3356)] - test(api): fix share role update test scenario \[[#3322](opencloud-eu/opencloud#3322)] - test: add api tests for cross-space search index mutation \[[#3320](opencloud-eu/opencloud#3320)] - ci: run search acceptance tests against OpenSearch in nightly \[[#3302](opencloud-eu/opencloud#3302)] - api-test: notification settings and getting email notifications \[[#3281](opencloud-eu/opencloud#3281)] - api-test: add posixfs scan and consistency CLI tests \[[#3263](opencloud-eu/opencloud#3263)] - api-test: replace sleeps with WaitHelper poll for async state \[[#3239](opencloud-eu/opencloud#3239)] ##### 📈 Enhancement - feat(thumbnails): extend list of default resolutions \[[#3386](opencloud-eu/opencloud#3386)] - ability to disable grpc and/or event consumer for event history service \[[#3279](opencloud-eu/opencloud#3279)] - feat(graph): add LibreGraphContentType on drive \[[#3355](opencloud-eu/opencloud#3355)] - feat: update space template image \[[#3324](opencloud-eu/opencloud#3324)] - feat(web): add rclone-crypt to default apps \[[#3313](opencloud-eu/opencloud#3313)] - enhance: send events for adding/removing favourite items \[[#3229](opencloud-eu/opencloud#3229)] - allow tuning the proxies http client \[[#3278](opencloud-eu/opencloud#3278)] - feat(web): add yjsServerUrl config \[[#3259](opencloud-eu/opencloud#3259)] - feat(posixfs): [#3182](opencloud-eu/opencloud#3182) add basepath option in the "posixfs scan" command \[[#3235](opencloud-eu/opencloud#3235)] ##### 🐛 Bug Fixes - fix(search): refresh the opensearch index after a write \[[#3388](opencloud-eu/opencloud#3388)] - fix(thumbnails): respect the requested height in libvips builds \[[#3377](opencloud-eu/opencloud#3377)] - refactor datagateway into proxy middleware \[[#3289](opencloud-eu/opencloud#3289)] - Only log a debug message when an item is still in processing state \[[#3158](opencloud-eu/opencloud#3158)] - fix(postprocessing): retry publishing events instead of killing the server \[[#3347](opencloud-eu/opencloud#3347)] - actually log error on exit \[[#3344](opencloud-eu/opencloud#3344)] - fix(activitylog): log missing parent id cache entry at debug level \[[#3325](opencloud-eu/opencloud#3325)] - fix restore file version for shared resource \[[#3268](opencloud-eu/opencloud#3268)] - Fix missing favorite flag on opensearch hits \[[#3252](opencloud-eu/opencloud#3252)] ##### 📚 Documentation - docs: clarify custom role bootstrap behavior \[[#3366](opencloud-eu/opencloud#3366)] ##### 📦️ Dependencies - \[full-ci] chore: bump web to v7.4.0 \[[#3399](opencloud-eu/opencloud#3399)] - build(deps): bump google.golang.org/grpc from 1.83.0 to 1.83.1 \[[#3396](opencloud-eu/opencloud#3396)] - build(deps): bump github.com/stretchr/testify from 1.12.0 to 1.12.1 \[[#3395](opencloud-eu/opencloud#3395)] - build(deps): bump github.com/go-chi/chi/v5 from 5.3.1 to 5.3.2 \[[#3394](opencloud-eu/opencloud#3394)] - build(deps): bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.29.0 to 2.30.0 \[[#3380](opencloud-eu/opencloud#3380)] - build(deps): bump golang.org/x/image from 0.44.0 to 0.45.0 \[[#3381](opencloud-eu/opencloud#3381)] - build(deps): bump github.com/beevik/etree from 1.7.0 to 1.7.1 \[[#3382](opencloud-eu/opencloud#3382)] - build(deps): bump github.com/nats-io/nats-server/v2 from 2.14.4 to 2.14.5 \[[#3357](opencloud-eu/opencloud#3357)] - build(deps): bump go.opentelemetry.io/contrib/zpages from 0.69.0 to 0.70.0 \[[#3360](opencloud-eu/opencloud#3360)] - build(deps): bump github.com/sirupsen/logrus from 1.9.4 to 1.10.0 \[[#3359](opencloud-eu/opencloud#3359)] - chore: bump reva to latest main \[[#3329](opencloud-eu/opencloud#3329)] - build(deps): bump github.com/stretchr/testify from 1.11.1 to 1.12.0 \[[#3341](opencloud-eu/opencloud#3341)] - build(deps): bump golang.org/x/net from 0.57.0 to 0.58.0 \[[#3342](opencloud-eu/opencloud#3342)] - build(deps): bump github.com/onsi/ginkgo/v2 from 2.32.0 to 2.32.1 \[[#3340](opencloud-eu/opencloud#3340)] - build(deps): bump github.com/testcontainers/testcontainers-go/modules/opensearch from 0.43.0 to 0.44.0 \[[#3303](opencloud-eu/opencloud#3303)] - build(deps): bump github.com/opencloud-eu/libre-graph-api-go \[[#3326](opencloud-eu/opencloud#3326)] - build(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace from 1.44.0 to 1.45.0 \[[#3306](opencloud-eu/opencloud#3306)] - build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.69.0 to 0.70.0 \[[#3305](opencloud-eu/opencloud#3305)] - build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.44.0 to 1.45.0 \[[#3280](opencloud-eu/opencloud#3280)] - build(deps): bump github.com/rogpeppe/go-internal from 1.15.0 to 1.16.0 \[[#3250](opencloud-eu/opencloud#3250)] - build(deps): bump github.com/kovidgoyal/imaging from 1.8.22 to 1.8.23 \[[#3135](opencloud-eu/opencloud#3135)] - build(deps): bump go.opentelemetry.io/otel/trace from 1.44.0 to 1.45.0 \[[#3266](opencloud-eu/opencloud#3266)]

@AlexAndBear

#1842) ##### [\`7.5.0\`](https://github.com/opencloud-eu/opencloud/blob/HEAD/CHANGELOG.md#750---2026-08-25) ##### ❤️ Thanks to all contributors! ❤️ [@AlexAndBear](https://github.com/AlexAndBear), [@JammingBen](https://github.com/JammingBen), [@Svanvith](https://github.com/Svanvith), [@aduffeck](https://github.com/aduffeck), [@butonic](https://github.com/butonic), [@fschade](https://github.com/fschade), [@junkerderprovinz](https://github.com/junkerderprovinz), [@kulmann](https://github.com/kulmann), [@maki5](https://github.com/maki5), [@pbleser-oc](https://github.com/pbleser-oc), [@rhafer](https://github.com/rhafer), [@saw-jan](https://github.com/saw-jan), [@schweigisito](https://github.com/schweigisito), [@v-scharf](https://github.com/v-scharf) ##### ✅ Tests - test(api): update php test dependencies \[[#3335](opencloud-eu/opencloud#3335)] - fix(acceptance): fix running acceptance tests against host on Linux \[[#3358](opencloud-eu/opencloud#3358)] - fix(graph): adding the same user as multiple members in a group ([#3354](opencloud-eu/opencloud#3354)) \[[#3356](opencloud-eu/opencloud#3356)] - test(api): fix share role update test scenario \[[#3322](opencloud-eu/opencloud#3322)] - test: add api tests for cross-space search index mutation \[[#3320](opencloud-eu/opencloud#3320)] - ci: run search acceptance tests against OpenSearch in nightly \[[#3302](opencloud-eu/opencloud#3302)] - api-test: notification settings and getting email notifications \[[#3281](opencloud-eu/opencloud#3281)] - api-test: add posixfs scan and consistency CLI tests \[[#3263](opencloud-eu/opencloud#3263)] - api-test: replace sleeps with WaitHelper poll for async state \[[#3239](opencloud-eu/opencloud#3239)] ##### 📈 Enhancement - feat(thumbnails): extend list of default resolutions \[[#3386](opencloud-eu/opencloud#3386)] - ability to disable grpc and/or event consumer for event history service \[[#3279](opencloud-eu/opencloud#3279)] - feat(graph): add LibreGraphContentType on drive \[[#3355](opencloud-eu/opencloud#3355)] - feat: update space template image \[[#3324](opencloud-eu/opencloud#3324)] - feat(web): add rclone-crypt to default apps \[[#3313](opencloud-eu/opencloud#3313)] - enhance: send events for adding/removing favourite items \[[#3229](opencloud-eu/opencloud#3229)] - allow tuning the proxies http client \[[#3278](opencloud-eu/opencloud#3278)] - feat(web): add yjsServerUrl config \[[#3259](opencloud-eu/opencloud#3259)] - feat(posixfs): [#3182](opencloud-eu/opencloud#3182) add basepath option in the "posixfs scan" command \[[#3235](opencloud-eu/opencloud#3235)] ##### 🐛 Bug Fixes - fix(search): refresh the opensearch index after a write \[[#3388](opencloud-eu/opencloud#3388)] - fix(thumbnails): respect the requested height in libvips builds \[[#3377](opencloud-eu/opencloud#3377)] - refactor datagateway into proxy middleware \[[#3289](opencloud-eu/opencloud#3289)] - Only log a debug message when an item is still in processing state \[[#3158](opencloud-eu/opencloud#3158)] - fix(postprocessing): retry publishing events instead of killing the server \[[#3347](opencloud-eu/opencloud#3347)] - actually log error on exit \[[#3344](opencloud-eu/opencloud#3344)] - fix(activitylog): log missing parent id cache entry at debug level \[[#3325](opencloud-eu/opencloud#3325)] - fix restore file version for shared resource \[[#3268](opencloud-eu/opencloud#3268)] - Fix missing favorite flag on opensearch hits \[[#3252](opencloud-eu/opencloud#3252)] ##### 📚 Documentation - docs: clarify custom role bootstrap behavior \[[#3366](opencloud-eu/opencloud#3366)] ##### 📦️ Dependencies - \[full-ci] chore: bump web to v7.4.0 \[[#3399](opencloud-eu/opencloud#3399)] - build(deps): bump google.golang.org/grpc from 1.83.0 to 1.83.1 \[[#3396](opencloud-eu/opencloud#3396)] - build(deps): bump github.com/stretchr/testify from 1.12.0 to 1.12.1 \[[#3395](opencloud-eu/opencloud#3395)] - build(deps): bump github.com/go-chi/chi/v5 from 5.3.1 to 5.3.2 \[[#3394](opencloud-eu/opencloud#3394)] - build(deps): bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.29.0 to 2.30.0 \[[#3380](opencloud-eu/opencloud#3380)] - build(deps): bump golang.org/x/image from 0.44.0 to 0.45.0 \[[#3381](opencloud-eu/opencloud#3381)] - build(deps): bump github.com/beevik/etree from 1.7.0 to 1.7.1 \[[#3382](opencloud-eu/opencloud#3382)] - build(deps): bump github.com/nats-io/nats-server/v2 from 2.14.4 to 2.14.5 \[[#3357](opencloud-eu/opencloud#3357)] - build(deps): bump go.opentelemetry.io/contrib/zpages from 0.69.0 to 0.70.0 \[[#3360](opencloud-eu/opencloud#3360)] - build(deps): bump github.com/sirupsen/logrus from 1.9.4 to 1.10.0 \[[#3359](opencloud-eu/opencloud#3359)] - chore: bump reva to latest main \[[#3329](opencloud-eu/opencloud#3329)] - build(deps): bump github.com/stretchr/testify from 1.11.1 to 1.12.0 \[[#3341](opencloud-eu/opencloud#3341)] - build(deps): bump golang.org/x/net from 0.57.0 to 0.58.0 \[[#3342](opencloud-eu/opencloud#3342)] - build(deps): bump github.com/onsi/ginkgo/v2 from 2.32.0 to 2.32.1 \[[#3340](opencloud-eu/opencloud#3340)] - build(deps): bump github.com/testcontainers/testcontainers-go/modules/opensearch from 0.43.0 to 0.44.0 \[[#3303](opencloud-eu/opencloud#3303)] - build(deps): bump github.com/opencloud-eu/libre-graph-api-go \[[#3326](opencloud-eu/opencloud#3326)] - build(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdouttrace from 1.44.0 to 1.45.0 \[[#3306](opencloud-eu/opencloud#3306)] - build(deps): bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.69.0 to 0.70.0 \[[#3305](opencloud-eu/opencloud#3305)] - build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.44.0 to 1.45.0 \[[#3280](opencloud-eu/opencloud#3280)] - build(deps): bump github.com/rogpeppe/go-internal from 1.15.0 to 1.16.0 \[[#3250](opencloud-eu/opencloud#3250)] - build(deps): bump github.com/kovidgoyal/imaging from 1.8.22 to 1.8.23 \[[#3135](opencloud-eu/opencloud#3135)] - build(deps): bump go.opentelemetry.io/otel/trace from 1.44.0 to 1.45.0 \[[#3266](opencloud-eu/opencloud#3266)] Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

maki5 added 2 commits August 10, 2026 14:36

ability to disable grpc and/or event consumer for event history service

4838167

uneeded type conversion

695f6a9

maki5 requested a review from butonic August 10, 2026 13:32

maki5 added the Type:Enhancement label Aug 10, 2026

maki5 mentioned this pull request Aug 10, 2026

[FR] Starting Event Listeners should be optional #1312

Open

7 of 8 tasks

butonic reviewed Aug 11, 2026

View reviewed changes

Comment thread services/eventhistory/pkg/command/server.go Outdated

butonic reviewed Aug 11, 2026

View reviewed changes

Comment thread services/eventhistory/pkg/config/parser/parse.go

eventhistory: debug service always enabled

fec4640

butonic reviewed Aug 12, 2026

View reviewed changes

eventhistory service: fix consumer isolation and conditional initiali…

6e87f66

…zation

maki5 requested a review from butonic August 14, 2026 10:55

maki5 added 2 commits August 14, 2026 13:30

Merge branch 'main' of github.com:opencloud-eu/opencloud into feat/ev…

4e5bef9

…enthistory_event_handler_on_demand

eventhistory: moved consumer related actions to it's constructor

1d55c4d

maki5 added the Status:Needs-Review label Aug 19, 2026

butonic approved these changes Aug 21, 2026

View reviewed changes

butonic merged commit 9796123 into main Aug 21, 2026
63 of 64 checks passed

butonic deleted the feat/eventhistory_event_handler_on_demand branch August 21, 2026 11:31

openclouders mentioned this pull request Aug 21, 2026

🎉 Release 7.5.0 #3238

Merged

Navigation Menu

Repository navigation

ability to disable grpc and/or event consumer for event history service - #3279

ability to disable grpc and/or event consumer for event history service#3279
butonic merged 6 commits into
mainfrom
feat/eventhistory_event_handler_on_demand

maki5 commented Aug 10, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

butonic Aug 12, 2026

Uh oh!

butonic Aug 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

maki5 commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codacy-production Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Uh oh!

Uh oh!

butonic Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

butonic Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

maki5 commented Aug 10, 2026 •

edited

Loading

codacy-production Bot commented Aug 10, 2026 •

edited

Loading