Implement realnum::rand by Mec-iS · Pull Request #251 · smartcorelib/smartcore

Mec-iS · 2023-03-20T13:14:54Z

Implement rand. Use the new derive [#default]

Fixes #214

Checklist

My branch is up-to-date with development branch.
Everything works and tested on latest stable Rust.
Coverage and Linting have been applied

Current behaviour

realnum::rand returns 1.0

New expected behaviour

random number is generated

* build(deps): update nalgebra requirement from 0.23.0 to 0.26.2 Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.26.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * fix: updates for nalgebre * test: explicitly call pow_mut from BaseVector since now it conflicts with nalgebra implementation * Don't be strict with dependencies Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.31.0) --- updated-dependencies: - dependency-name: nalgebra dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench

* Add example * Move to top * Add imports to example * Fix imports

* docs: Fix typo in doc for categorical transformer. * feat: Add option to take a column from Matrix. I created the method `Matrix::take_column` that uses the `Matrix::take`-interface to extract a single column from a matrix. I need that feature in the implementation of `StandardScaler`. * feat: Add `StandardScaler`. Authored-by: titoeb <timtoebrock@googlemail.com>

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

* Update criterion requirement from 0.3 to 0.4 Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.0...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix criterion Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* handle multiclass precision/recall

* grid search draft * hyperparam search for linear estimators

* feat: Add interface to build `Matrix` from rows. * feat: Add option to derive `RealNumber` from string. To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string. * feat: Implement `Matrix::read_csv`.

…#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

…nt-rand

…implement-rand

codecov-commenter · 2023-03-20T13:20:42Z

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.49%. Comparing base (7d059c4) to head (362c3f9).
⚠️ Report is 50 commits behind head on development.

Files with missing lines	Patch %	Lines
src/ensemble/random_forest_classifier.rs	66.66%	1 Missing ⚠️
src/tree/decision_tree_classifier.rs	66.66%	1 Missing ⚠️
src/tree/decision_tree_regressor.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #251      +/-   ##
===============================================
+ Coverage        44.36%   44.49%   +0.12%     
===============================================
  Files               85       85              
  Lines             7220     7226       +6     
===============================================
+ Hits              3203     3215      +12     
+ Misses            4017     4011       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Mec-iS · 2023-03-20T13:40:46Z

thanks @morenol
I need a 0.3.1 release asap! 👍🏼

morenol · 2023-03-20T13:42:25Z

thanks @morenol I need a 0.3.1 release asap! 👍🏼

Can you bump the version on this PR?

morenol

LGTM but not sure why ignore was added to one of the doc tests

Mec-iS · 2023-03-20T13:55:40Z

LGTM but not sure why ignore was added to one of the doc tests

that test uses datasets feature so it fails, it is replicated among the tests with the right flag.

I may have more changes in the next hours, I am adding anti-panicking checks to fit methods.

morenol · 2023-03-20T13:57:05Z

I may have more changes in the next hours, I am adding anti-panicking checks to fit methods.

I like that idea!

morenol · 2023-03-20T13:59:18Z

It seems that there is conflicts, it says to me that there are 83 commits on this PR, could you rebase?

Mec-iS · 2023-03-20T14:35:14Z

It seems that there is conflicts, it says to me that there are 83 commits on this PR, could you rebase?

that is because I pushed the wrong branch at the creation of the PR, then I corrected it.
Check in "Files Changed" that the changes are only the latest ones.

EDIT: your local branch may be missing the "Update README.md" I pushed before this PR.

dependabot-preview Bot and others added 30 commits November 8, 2022 11:29

Add SVC::decision_function (#135)

ea39024

Fix clippy warnings (#139)

98e3465

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Added additional doctest and fixed indices (#141)

eb4b49d

Implement fastpair (#142)

dc7f01d

* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench

Add example for FastPair (#144)

09d9205

* Add example * Move to top * Add imports to example * Fix imports

Add serde for StandardScaler (#148)

01f753f

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

Handle multiclass precision/recall (#152)

0f442e9

* handle multiclass precision/recall

grid search (#154)

1f2597b

* grid search draft * hyperparam search for linear estimators

fix: fix compilation warnings when running only with default features (…

f291b71

…#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Update LICENSE

0d996ed

Make rand_distr optional (#161)

851533d

feat: allocate first and then proceed to create matrix from Vec of Ro… (

bb5b437

#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

Provide better output in flaky tests (#163)

cfa824d

Complete grid search params (#166)

55e1158

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

Lmm/add seeds in more algorithms (#164)

a37b552

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

add seed param to search params (#168)

05dfffa

make default params available to serde (#167)

f4fd4d2

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

Add contribution guidelines (#178)

e4c47c7

Update CONTRIBUTING.md

9ea3133

feat: expose hyper tuning module in model_selection (#179)

ad2e6c2

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

refactor: Try to follow similar pattern to other APIs (#180)

473cdfc

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

fix: fix issue with iterator for svc search (#182)

d520007

Update CONTRIBUTING.md

d015b12

Update README.md

3b1aaaa

Update README.md

f605f6e

Mec-iS and others added 9 commits November 8, 2022 11:29

Update CHANGELOG

c507d97

use getrandom/js

b0dece9

update comment

2f6dd13

update CHANGELOG

e25e2ae

make work cargo build --target wasm32-unknown-unknown

265fd55

Fixes for release (#237)

7d87451

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

Handle kernel serialization (#232)

62de25b

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

Merge

0c9c70f

Implement rand. Use the new derive [#default]

bcaf381

Mec-iS requested a review from morenol March 20, 2023 13:14

Mec-iS added 2 commits March 20, 2023 22:15

Merge branch 'main' of github.com:smartcorelib/smartcore into impleme…

82e2e98

…nt-rand

Merge branch 'development' of github.com:smartcorelib/smartcore into …

c5ccce9

…implement-rand

morenol reviewed Mar 20, 2023

View reviewed changes

Comment thread src/numbers/realnum.rs Outdated

Use custom range

d94b7d0

morenol reviewed Mar 20, 2023

View reviewed changes

Comment thread src/numbers/realnum.rs Outdated

Mec-iS added 2 commits March 20, 2023 22:44

Use range seed

0541265

Bump version

6822dd5

morenol reviewed Mar 20, 2023

View reviewed changes

Comment thread src/cluster/dbscan.rs

morenol previously approved these changes Mar 20, 2023

View reviewed changes

Add array length checks for

362c3f9

Mec-iS dismissed morenol’s stale review via 362c3f9 March 20, 2023 14:34

Mec-iS merged commit f498f96 into development Mar 20, 2023

Mec-iS deleted the implement-rand branch March 20, 2023 14:45

Navigation Menu

Uh oh!

Implement realnum::rand - #251

Implement realnum::rand#251
Mec-iS merged 84 commits into
developmentfrom
implement-rand

Mec-iS commented Mar 20, 2023

Uh oh!

codecov-commenter commented Mar 20, 2023 •

edited by codecov Bot

Loading

Uh oh!

Uh oh!

Mec-iS commented Mar 20, 2023

Uh oh!

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

Uh oh!

morenol left a comment

Uh oh!

Mec-iS commented Mar 20, 2023

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

Mec-iS commented Mar 20, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Mec-iS commented Mar 20, 2023

Checklist

Current behaviour

New expected behaviour

Uh oh!

codecov-commenter commented Mar 20, 2023 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Mec-iS commented Mar 20, 2023

Uh oh!

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

Uh oh!

morenol left a comment

Choose a reason for hiding this comment

Uh oh!

Mec-iS commented Mar 20, 2023

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

morenol commented Mar 20, 2023

Uh oh!

Mec-iS commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov-commenter commented Mar 20, 2023 •

edited by codecov Bot

Loading

Mec-iS commented Mar 20, 2023 •

edited

Loading