Skip to content

Fix the Release job: drop @workflow/world-sim from the hook_conflict delta changeset - #3963

Merged
pranaygp merged 1 commit into
mainfrom
pgp/fix-publish-changesets
Sep 3, 2026
Merged

pranaygp merged 1 commit into
mainfrom
pgp/fix-publish-changesets

Conversation

@pranaygp

@pranaygp pranaygp commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Problem

The Release workflow has failed on every push to main since #3938 landed, so no beta has been published:

changeset version aborts before doing anything:

🦋  error Error: Found mixed changeset hook-conflict-delta-worlds
🦋  error Found ignored packages: @workflow/world-sim
🦋  error Found not ignored packages: @workflow/world @workflow/world-local
🦋  error Mixed changesets that contain both ignored and not ignored packages are not allowed

.changeset/hook-conflict-delta-worlds.md (added by #3938, my PR) bumps @workflow/world-sim alongside @workflow/world and @workflow/world-local. @workflow/world-sim is private and listed under ignore in .changeset/config.json, and changesets refuses a changeset that mixes ignored and published packages.

Fix

Remove the @workflow/world-sim line. The package is never published, so it has no changelog to lose. pnpm changeset version now completes locally (verified, then reverted).

Nothing at PR time validates changesets today, and pnpm changeset status --since=main does not catch this either when run on the merge commit. A follow-up PR adds a CI check that assembles the release plan the way changeset version does, so the next one of these fails on the PR instead of on main.

No changeset: this PR only edits an existing changeset file.

🤖 Generated with Claude Code

…elta changeset

Changesets refuses a changeset that mixes packages in the `ignore` list
with published ones, so `changeset version` has failed on every push to
main since #3938 and nothing has been published.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@pranaygp
pranaygp requested a review from a team as a code owner September 3, 2026 21:24
Copilot AI lite review requested due to automatic review settings September 3, 2026 21:24
@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 10f31c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 20 packages
Name Type
@workflow/world Patch
@workflow/world-local Patch
@workflow/cli Patch
@workflow/core Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
@workflow/world-postgres Patch
@workflow/world-testing Patch
@workflow/world-vercel Patch
workflow Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenario outcome events virt replay violations
✅ smoke-no-steps completed 3 0ms ok 0
✅ smoke-one-step completed 6 0ms ok 0
✅ hook-at-step-started completed 12 0ms ok 0
✅ hook-at-step-completed completed 12 0ms ok 0
✅ hook-at-hook-created completed 12 0ms ok 0
✅ deadline-hook-wins completed 7 1.0h ok 0
✅ deadline-expires completed 7 1.0h ok 0
✅ long-sleep completed 11 30.0d ok 0
✅ hook-never-arrives stalled 3 0ms skipped 0
✅ step-retries-twice completed 10 2.0s ok 0
✅ parallel-steps completed 9 0ms ok 0
✅ hook-on-execution-state completed 12 0ms ok 0
✅ peek-hook-before-branch completed 12 0ms ok 0
✅ peek-hook-after-branch completed 12 0ms ok 0
✅ peek-hook-at-registration completed 12 0ms ok 0
✅ race-hook-before-probe completed 12 0ms ok 0
✅ race-hook-after-probe completed 12 0ms ok 0
✅ race-duplicate-delivery completed 13 0ms ok 0
✅ attr-hook-before-step completed 11 0ms ok 0
✅ attr-hook-after-step completed 11 0ms ok 0
✅ attr-from-step-body completed 13 0ms ok 0
✅ fork-hook-after-timeout completed 14 1.0m ok 0
✅ fork-hook-before-timeout completed 14 1.0m ok 0
✅ count-hook-after-timeout completed 17 1.0m ok 0
✅ count-hook-before-timeout completed 20 1.0m ok 0
✅ stale-read-step-count-fork completed 20 1.0m ok 0
✅ stale-read-equal-step-counts completed 14 1.0m ok 0
✅ step-vs-step-fork completed 12 0ms ok 0
✅ step-vs-step-fork-fenced completed 12 0ms ok 0
✅ fence-catches-benign-direction completed 12 5ms ok 0
✅ in-flight-before-decision completed 17 1.0m ok 0
❌ in-flight-before-decision-counted completed 17 1.0m ok 0
✅ in-flight-after-decision completed 19 2.0m ok 0
✅ stale-read-step-count-fork-fenced completed 20 1.0m ok 0
✅ fork-hook-wins completed 13 1.0m ok 0
✅ fork-timeout-wins completed 13 1.0m ok 0
✅ unclaimed-payload-under-fork completed 17 1.0m ok 0
✅ claimed-payload-under-fork completed 17 1.0m ok 0
✅ writers-independent-step-bodies completed 12 0ms ok 0
✅ writers-scripted-tempo completed 12 0ms ok 0
✅ cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, correct adjustment to the changeset frontmatter that resolves the documented Changesets constraint without affecting runtime code.

Pull request overview

Fixes the release workflow failure caused by a mixed changeset that included both ignored and published packages, which prevented changeset version from running on main.

Changes:

  • Removes @workflow/world-sim from .changeset/hook-conflict-delta-worlds.md so the changeset only references publishable packages.
File summaries
File Description
.changeset/hook-conflict-delta-worlds.md Drops @workflow/world-sim from the changeset to avoid mixing ignored and non-ignored packages during release plan generation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pranaygp
pranaygp merged commit 63143e5 into main Sep 3, 2026
61 of 65 checks passed
@pranaygp
pranaygp deleted the pgp/fix-publish-changesets branch September 3, 2026 21:27
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 63143e5 (AI decision).

This commit only edits .changeset/hook-conflict-delta-worlds.md, a changeset file that does not exist on stable (git ls-tree origin/stable -- .changeset/hook-conflict-delta-worlds.md returns nothing), so there is nothing to fix there. It is a changesets-only release-plumbing correction scoped to main's pending release plan; if the underlying #3938 change is ever backported, the corrected changeset should be authored as part of that backport instead.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

63143e5f8456cfdb0a2f20c140565499050a8091

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
workflow-swc-playground Ready Ready Preview, v0 Sep 3, 2026 9:29pm UTC

pranaygp added a commit that referenced this pull request Sep 3, 2026
…Release job

`changeset version` assembles a release plan from every pending changeset
before it bumps anything, and throws on a changeset it cannot place there:
one naming a package outside the workspace, or one mixing a package from
the `ignore` list with published ones. #3938 shipped the latter and every
push to main since has failed to publish (#3963). Nothing at PR time ran
that step.

scripts/check-changesets.mjs runs the same assembly on the same inputs,
resolving the libraries from @changesets/cli's own install so the check
uses exactly the versions the Release job does, and stops before the
network-bound changelog generation. lint.yml runs it on every PR.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
pranaygp added a commit that referenced this pull request Sep 4, 2026
…Release job (#3964)

`changeset version` assembles a release plan from every pending changeset
before it bumps anything, and throws on a changeset it cannot place there:
one naming a package outside the workspace, or one mixing a package from
the `ignore` list with published ones. #3938 shipped the latter and every
push to main since has failed to publish (#3963). Nothing at PR time ran
that step.

scripts/check-changesets.mjs runs the same assembly on the same inputs,
resolving the libraries from @changesets/cli's own install so the check
uses exactly the versions the Release job does, and stops before the
network-bound changelog generation. lint.yml runs it on every PR.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
pranaygp added a commit that referenced this pull request Sep 9, 2026
…c-workflow-source

* origin/main: (22 commits)
  feat(streams): add writer session seam (#3832)
  docs: document WORKFLOW_NODE_HTTP in the v4 World docs (#4050)
  [world-vercel] Honor WORKFLOW_NODE_HTTP on the queue transport (#4044)
  feat(streams): add WebSocket capability gate (#3764)
  fix(world-local): retry JSON reads on Windows (#4051)
  [core] Add the wake-loop scenario to the event log race repro (#4017)
  [ci] Cap concurrent Vercel E2E action repo-wide (10 by default) (#4039)
  Add `Run#getWritable()` for appending to another run's stream (#3972)
  feat(streams): add WebSocket v1 client protocol contract (#3763)
  [swc-playground] Update to Next.js v16.3.4 (#4018)
  [core] Add a retention option to start() (#3787)
  fix(swc-plugin): register class expressions via an IIFE instead of by name (#3971)
  [docs] Fix prose typos across v4/v5 docs and the SWC plugin README (#3948)
  Validate pending changesets in CI so a bad one fails the PR, not the Release job (#3964)
  Version Packages (beta) (#3919)
  Classify Workflow stream failures (#3850)
  Drop the ignored @workflow/world-sim package from the hook_conflict delta changeset (#3963)
  Add attribute inspection to the CLI (#3950)
  [core] Settle a hook's awaiter in-process instead of re-invoking, on creation and on conflict (#3938)
  Use the storage APIs for run detail views (#3944)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants