fix(schema): default omitted capability tools for custom providers - #49940
Open
cestercian wants to merge 2 commits into
Open
cestercian wants to merge 2 commits into
cestercian wants to merge 2 commits into
Conversation
Unknown models already assume tool support. Accept capabilities that omit tools so migrated V1 custom providers are not skipped, and name the malformed field in normalization diagnostics.
Update existing diagnostic path assertions now that invalid values include the offending schema field.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 of 6 tasks
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #49912
Type of change
What does this PR do?
Custom providers migrated from V1 often omit
capabilities.tools(V1 only had modalities). The schema requiredtools, so the whole provider was skipped with a terse normalization warning and/api/configshowed empty providers.Unknown models already assume tool support. This makes omitted
toolsdecode astrue(explicitfalsestill wins), and invalid diagnostics now include the offending schema field (e.g.$.providers.acme.models.coder.capabilities.tools) instead of only the provider path.How did you verify your code works?
From
packages/schema:bun test test/model.test.ts test/config.test.ts— 15 passbun typecheck— passFrom
packages/core:bun test test/config/normalization.test.ts test/config/provider.test.ts— 54 passbun typecheck— passScreenshots / recordings
N/A — schema/normalization covered by unit tests.
Checklist